thewhitewolves / mapchange Goto Github PK

https://app.roll20.net/forum/permalink/3491471/

I can't seem to get the inverted private mode to work. Using the Github 1.2 version.

invertedMarker = true and the list behaves as default. [GM] maps are in private while unlabelled maps are in public.

EDIT: The plot thickens. I have no idea why, but the inversion now works in the API.
"{"debug":true,"gmNotify":true,"marker":"[GM]","invertedMarker":true}"

However, when I copy pasted the script from that API to another game, the inversion doesn't work:
"{"debug":true,"gmNotify":true,"marker":"[GM]","invertedMarker":false}"

Didn't change a thing between the copy/paste, nor are either game running any other APIs.
I have no idea what happened.

See the above post, it looks like on first loading the script into a new campaign it is not loading the users changes to the config into the state, it is loading the hard coded defaults and then pulls the users change on the second load.

https://app.roll20.net/forum/permalink/3481781/

The github version worked.

How about you add an optional tag? I have a LOT of maps, so when I use the menu it stretches far. Why not have two tags? [Public] and [Private]? Show only those that have those tags, in their correct list, while those untagged would be invisible.

https://app.roll20.net/forum/permalink/3481805/

I see your point, I'll look at it for v1.3, I'll probably implement it as an additional tag by default and I'll have to think about the inverted behaviour.

https://app.roll20.net/forum/permalink/3481868/

Just have two behaviors. One for two tags and the second for one tag. If the user specifies the optional tag, then it switches to two tag mode.

Add the help menu so users can understand the script better.

Documentation todo:

• !mc refresh
• !mc rejoin
• !mc rejoin [player name]
• !mc move [map name]
• !mc move [player name] [map name]
• !mc moveall [map name]
• !mc menu
• !mc help

currently custom html formatting can only be applied if you use "/direct" as the chat type, this unfortunately means that html formatting cannot be applied to whispering.

see [API] /direct for whispers suggestion for this.

because we do not want to send links to private maps to the players (even though they can't use them), this is limiting us to no html formatting because whispers must be used.

Implement splitting using -- as an identifier

e.g. on line 71

var args = msg.content.split(/\s+--/);

this may allow use of optional parameters, i.e. !mc move --player TheWhiteWolves --target World Map - Realm 1

Possible idea:

Seperate archived maps from the listing and give them their own section with public and private, then just put an api button in their place on the menu that launches !mc menu --show archive to show the archived maps.

Add a chat message for gmNotify to the !mc refresh command to say something like "Refresh Complete"

When using /w to whisper to a person it will only use the first part of any name that has a space in it.

e.g. Jonathan Smith uses /w Jonathan to whisper and then includes Smith in the whisper text.

https://app.roll20.net/forum/permalink/3481680/

The inverted doesn't seem to work. I have one map with [GM] marker and it still is in Private, like the rest of the maps.

Turning off Debug Mode doesn't work. It will always set itself to true.

The Other command in !mc menu and most likely any time a gm manually uses the command to move a different player doesn't say who actually moved.

Possibly add in a lock / blacklist that can be used to stop a player from using any of the scripts commands.

Use Case:

For players who are abusing the teleport or causing it to spam the GM if they have notifications turned on.

Need to add a help entry to explain about adding the marker to a maps name to make it private.

Also add information about Inverted Marker.

https://app.roll20.net/forum/permalink/3515348/

A new feature - Rejoin All to bookmark would be nice.

https://github.com/TheWhiteWolves/MapChange/blob/master/MapChange.js#L635-L645

Needs to be added to the help in the above location.

Add in a menu command, this command will send a menu to the chat with a list of the map names and buttons to allow a player to use this to move between pages instead of either manually sending the command or using a macro.

public maps will display for players and GMs
private maps will only display for GMs

When the command is used a table will be generated and sent to the player, following the bellow example:

Player View:

GM View:

[ ] is a placeholder for a button in the chat

When first adding the script the default values are entered into the state and thus are correct, however once a change is made to the global config and pulled in the marker variable is not being pulled correctly and others may not be working.

First instance:

After Global Config change: