Comments (6)
@hellais Wouldn't be cleaner to add the probe_id with ooniprobe annotations parameter instead?
from lepidopter.
I think in general passing configuration options as command line arguments is not very good approach. It also means that when ooniprobe-agent is released this will no longer be applicable.
from lepidopter.
Since this is going to change in ooniprobe-agent makes more sense to have the probe_id
defined in ooniprobe.conf
this way other people that are not submiting reports via lepidopter can set annotations. Does this makes sense?
from lepidopter.
I think it should also be separate from the configuration file given the fact that we don't want the probe_id to be something that is set by the user, but rather automatically generated by the software itself.
We also want to have the ability to allow the user to re-generate their probe_id value and if we put this inside of the configuration file it's not going to be possible to change just that attribute without loosing comments.
That is why I am suggesting we either put it inside of /etc/
or inside of /var/lib/ooni
from lepidopter.
Quoting @hellais in IRC:
#59 is https://github.com/TheTorProject/ooni-probe/issues/438 and I think we will not include it in the short term.
@hellais is this still needed to be implemented in lepidopter?
from lepidopter.
Yes this should be part of the probe authorship system and should not be implemented as a lepidopter specific feature.
from lepidopter.
Related Issues (20)
- Libraries missing for measuing temperature on Raspberry HOT 1
- Change name to OONI Probe HOT 42
- Missing Middle Box HOT 1
- Can i install lepidopter on LXC? HOT 1
- ooniprobe is not running and web interface fails to load decks and recent results HOT 11
- Upload un-submitted reports with a tighter interval HOT 6
- Run the default deck as soon as the raspberry pi boots up HOT 1
- Potential improvements for lepidopter HOT 4
- Build a lepidopter image that does not perform the http-invalid-request-line test HOT 2
- Add Lantern, Psiphon and OpenVPN test dependencies HOT 2
- Add ooniprobe v2.0.0 stable in lepidopter HOT 2
- Document how to access lepidopter web interface HOT 1
- run_oonideckgen is not run when network is up HOT 2
- Zip file for 0.3.5 is possibly corrupt and GPG sig is missing HOT 1
- Restrict management interfaces to LAN
- The latest image doesn't fit on a 4GB card HOT 3
- Lepidopter image should be on the root PATH of the zip archive HOT 1
- Set a PATH that will not be rewritten by any lepidopter updates HOT 3
- Show simple webpage during update HOT 3
- Add a watchdog daemon to auto reboot a hung Raspberry PI HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from lepidopter.