Replace Glide\ImageRequest with HttpFoundation\Request about glide HOT 3 CLOSED

Okay, so I've just messed around with how you could manually create an instance of the Request object, and it can be done like so:

use Symfony\Component\HttpFoundation\Request;

$request = new Request(
    [
        'w' => (string) 100,
    ],
    [],
    [],
    [],
    [],
    [
        'REQUEST_URI' => '/rose.jpg'
    ]
);

Just a little messy, so a factory helper is probably smart.

from glide.

The other option is that we still allow the sending of the $filename and $params values to the method, and those methods just convert them into a Request object behind the scenes.

This sort of comes down to what is more likely. Will people prefer to send these in manually, or will they prefer to simply send an instance of the Request object? I sort of feel like the prior (two parameters) if they are using Glide within an app, and the later (request object) if they are using Glide as it's own image server.

# Option 1 (most likely used in image server)
public function outputImage(Request $request)
public function getImageResponse(Request $request)
public function makeImage(Request $request)

# Option 2 (most likely used within an app)
public function outputImage($filename, Array $params)
public function getImageResponse($filename, Array $params)
public function makeImage($filename, Array $params)

Would it be terrible if these methods accepted both options?

1. If the first parameter is an instance of Request, use it and ignore the second parameter.
2. If the first parameter is a string, use it with the second parameter (array) to create a new Request instance.

from glide.

Done: cfc837d

Ended up allowing three methods to accept either an instance of Request, or a string and array combination, which is automatically converted into a Request instance.

from glide.