Local adapter private directory visibility about flysystem HOT 5 OPEN

Hi, @olegkhuss this is intended behaviour. The directory permissions are write-mostly, as in, they have a second priority to the other methods. It can be part of a directory listing, but is not required. The visibility method is intended to be used for files, which is why you're getting an unexpected result. In practice, for file storage needs, directories are not super important. It's when people use Flysystem as an API for specific local filesystem operations that this is ...problematic.

from flysystem.

from flysystem.

@olegkhuss for clarity, V3 optimised a lot of paths to reduce the amount of expensive calls while retaining (almost) all functionality. It's better for the performance of your app and better for the environmental impact of running software to do less. This is why it changed.

from flysystem.

from flysystem.

It seems to me a bug still, the permissions in the filesystem are set correctly
but the code below doesn't return me the right value

$adapter = new LocalFilesystemAdapter(static::ROOT);

$adapter->createDirectory('public_directory', new Config(['visibility' => 'public']));
$publicVisibility = $adapter->visibility('public_directory');

$adapter->createDirectory('private_directory', new Config(['visibility' => 'private']));
$privateVisibility = $adapter->visibility('private_directory'); 

$this->assertEquals('public', $publicVisibility->visibility()); // okay
$this->assertEquals('private', $privateVisibility->visibility());  // ! failed, expect "private" but actual is "public"   

Now see the picture below, it returns me "public" in both cases whereas actual permissions are different?

from flysystem.