Leaving one parameter off the customizer causes crashes when custom music is used about randommetroidsolver HOT 4 OPEN

It was just pointed out to me that when it crashes, the Varia tracker's autotracking stops at loading room data. Based on the fact that the game crashes right as the room should start lighting up, I'm guessing the next room loads just fine, but when it's meant to go back to game code, that's when it gets thrown to a very wrong memory address, or to corrupted memory.

from randommetroidsolver.

thank you for your report, crashes have indeed been reported with custom music.
we'll try to investigate this customize everything except one thing, but it doesn't seem intuitive.

from randommetroidsolver.

Absolutely agree it doesn't seem intuitive. Perhaps a pointer is being set somewhere expecting all parameters to be customized, and not accounting for the missing data that comes with leaving a parameter out? Or maybe an extra stack push or pull is happening? I'm grasping at straws here, but those are my guesses as an outsider looking in.

from randommetroidsolver.

I've added some checks when the customizer writes data, with custom music, custom sprite and custom palettes:

In section custom_music.ips there 151 addresses
In section fusion_green_varia.ips there 260856 addresses
In section palette there 22218 addresses
In section music there 488795 addresses
No intersection found between custom_music.ips and fusion_green_varia.ips
No intersection found between custom_music.ips and palette
WARNING: intersection found between custom_music.ips and music -> updates a song table
WARNING: intersection found between fusion_green_varia.ips and palette -> updates colors in custom sprite and gunship
No intersection found between fusion_green_varia.ips and music
No intersection found between palette and music

the custom music section doesn't intersect with other customizer updates in the ROM.

from randommetroidsolver.