Comments (3)
I think that's already supported?
Chris Sinchok
Developer
730 N. Franklin St. #700
Chicago IL 60654
the Onion | "America's Finest News Source"
On Wed, Dec 17, 2014 at 1:48 PM, Adam Wentz [email protected]
wrote:
It might be nice to just pass a top-level element to picturefill which
would then find subelements to be picturefilled.—
Reply to this email directly or view it on GitHub
#41.
from betty-cropper.
I thought it did too, but that clickhole quiz image bug report from today led me to read through image.js a bit more carefully. I believe this line was making it appear to work: https://github.com/theonion/betty-cropper/blob/master/betty/cropper/templates/image.js#L45 Since the front-end js usually selects elements with jquery it would fall through to that case.
from betty-cropper.
Aw fuck, you're right. That's my bad.
Chris Sinchok
Developer
730 N. Franklin St. #700
Chicago IL 60654
the Onion | "America's Finest News Source"
On Wed, Dec 17, 2014 at 2:38 PM, Adam Wentz [email protected]
wrote:
I thought it did too, but that clickhole quiz image bug report from today
led me to read through image.js a bit more carefully. I believe this line
was making it appear to work:
https://github.com/theonion/betty-cropper/blob/master/betty/cropper/templates/image.js#L45
Since the front-end js usually selects elements with jquery it would fall
through to that case.—
Reply to this email directly or view it on GitHub
#41 (comment)
.
from betty-cropper.
Related Issues (20)
- Proper auth using django
- 0.3
- imgmin functionality
- Serve responsive image js
- Bandwidth/pixel density detection HOT 1
- Docs
- South migrations
- Change to markup results in error on refresh
- Allow for multiple simultaneous image uploads
- Infinite scroll keeps returning the last page
- Need uploader and date uploaded on image meta
- Rounding on image sizes
- Image Crop by Height HOT 3
- /api/new should return image type (and animated property?) HOT 1
- URL routes should match finite crop ratios
- Test against multiple versions of django HOT 1
- Create cropping view HOT 1
- Django admin widgets
- Base the ID splitting on the host filesystem
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from betty-cropper.