Feature Request: Update and unify CONTRIBUTING.md and the wiki about theodinproject HOT 2 OPEN

Looks like there was a regression of #4323 brought on by #4478 -- the CONTRIBUTING.md for this repo now says to run yarn test again, which should absolutely change. Maybe there can be a new page on the wiki about commands to run before submitting a PR?

The team settled on having separate CONTRIBUTING docs for handling repo specific concerns, so I wouldn't want to consolidate everything into the parent CONTRIBUTING doc. But other than that all of your ideas seem good here. Ditching the $ in the bash commands is a great idea to give a better copy/paste experience.

You still interested in making a PR (or PRs) for this? @scheals

Glad to answer any questions you have or give guidance on things if you want.

from theodinproject.

Hey @JoshDevHub, I am still interested albeit I am going to focus on the RuboCop lesson at the moment. After I'm done with that I am going to have to set up TOP locally once again from scratch, so then my experience will be fresh.

If someone gets to this before I can (which, if everything goes according to the plan should be around start of may) they should go ahead.

For sure whoever wants can change the testing bit right now could do so, that seems like a quick and important fix. Same with removing $s.

I wonder why the current Gemfile setting for Ruby version has not stopped joel from discord from running stuff. I seem to recall that I was trying to run someone's Rails app recently and I was stopped in my tracks because of a Gemfile-defined Ruby version being different from the one I had enabled (and, I didn't have the target Ruby version at all, in fact). Bundler docs seem to suggest that the current way to link .ruby-version with Gemfile is:

ruby file: ".ruby-version"

Aaand actually, scratch that, I just googled around and supposedly Heroku does not support this and the way it is implemented here should work. So what am I missing? bin/test does use bundle exec @_@

from theodinproject.