Advanced HTML and CSS - Keyframes: Animate transform instead of width and height about curriculum HOT 4 OPEN

Thanks @royalh23, @TheOdinProject/html-css can we get you're input on this one please?

from curriculum.

I think it makes sense to use a transform there instead.
Technically, transform: scale(2) is a little different in that it'll just scale the element itself, including border size, whereas animating the width/height will only change the space taken up by the element as a whole (regardless of box-sizing).

Don't think that's a differentiation that's important to include, and I can't think of many cases with that kind of animation where you'd purposely want to just change the width/height and not just scale the whole thing. Since the lesson says we have also specified that the ball double in **size.**, we should be fine to just replace the relevant code.

The codepen will need to be changed accordingly as well.

from curriculum.

Going to assign you @royalh23. I think changing the height/width adjustment to simply transform: scale(2); makes much more sense here (esp. since we've already covered transforms).

We will handle the codepen on our side so both parts are changed at roughly the same time.

from curriculum.

@MaoShizhong Gotcha. Will make a PR tomorrow

from curriculum.