Code Monkey home page Code Monkey logo

Comments (4)

thelsing avatar thelsing commented on July 28, 2024

I just pushed some changes that should resolve this. But now I'm not sure if this is necessary. What is the harm in returning true before restart? After Loading group address table, association table, group object table and application program the device is configured. Sure ETS sends an restart command next but that should not be necessary.

from knx.

Bernator avatar Bernator commented on July 28, 2024

In my case the application program gets initialized during setup() with some ETS Parameters, this is only possible if the device is configured. So if there is no configuration at startup the app is not getting initialized.
Further if knx.configured() returns true later in loop() without restart, the uninitilaized app is getting started for a short time until the restart comes. In my case the app hang and the restart was never processed.
Sure it would be possible to fix the app and do nothing in this case and wait for the restart but i think it is much more intuitive when the stack returns true only after the restart.
Back answer, what is the benefit of returning true before restart? :)

from knx.

thelsing avatar thelsing commented on July 28, 2024

Ok, seems like a valid reason for me. Can you test if it works correctly now?

from knx.

Bernator avatar Bernator commented on July 28, 2024

yes it works as expected, thx

from knx.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.