Code Monkey home page Code Monkey logo

Comments (6)

taras avatar taras commented on August 15, 2024

Related emberjs/ember.js#12114 but for us this might be quiet problematic. Thoughts?

from ember-let.

taras avatar taras commented on August 15, 2024

I believe it's possible to turn let into a class helper. Let me know if you'd like me to look into this.

from ember-let.

rwjblue avatar rwjblue commented on August 15, 2024

I believe it's possible to turn let into a class helper. Let me know if you'd like me to look into this.

There is no way to support the block param yielding with a class based helper.

from ember-let.

taras avatar taras commented on August 15, 2024

Thank you Robert.

from ember-let.

rwjblue avatar rwjblue commented on August 15, 2024

Since the helper registration is not tied to the container/registry of the app being booted, it doesn't really need to exist in an initializer at all. One possible solution would be to have a simple vendor/ember-let/register.js file that does something (pseudo code) like this:

var registerHelper = Ember.__loader.require('ember-htmlbars/helpers').registerHelper;
var letKeywordModule = require('ember-let/-private/keyword').default; // => we would need to move the keyword implementation here
registerHelper('let', letKeyword);

Then we do this from the included hook:

app.import('vendor/ember-let/register.js');

from ember-let.

taras avatar taras commented on August 15, 2024

@rwjblue I created a WIP PR with your suggestion. It's not working at the moment because it seems that the vendor file is loaded before ember-let modules become available. Any idea why this might be?

from ember-let.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.