Comments (10)
I have an idea on how to improve this, will let you know asap, perhaps tomorrow.
from bootstrap.native.
Works as intended. Many thanks for this enhancement!
from bootstrap.native.
@jcorporation I've played with the code a bit, I made it work to take this case into account and well... it's not right, mostly because the new positioning system based on position fixed
for the tooltip and a much more simple algorithm makes Popovers always stick to the viewport edges, even if their trigger elements are not in the viewport at all. In short, it solves one niche case and produces an even bigger problem for everything else.
In my mind a solution can be to use a custom CSS class with a top: YOUR_VALUE !important
position for your Popover and similar for it's arrow, since this is a very specific use case. It might also help us to implement the inserted.bs.popover
event (it shouldn't be hard at all) to update your Popover position however you want when this event triggers. Even better we can also add updated.bs.popover
but I think all this should benefit the community at large.
What do you think?
Happy New Year!!
from bootstrap.native.
This additional events should solve my problem. Could you add this events also to the dropdown component?
As reference my current patch to solve this: https://github.com/jcorporation/bootstrap.native/commit/73aa96402667ceb8e75fcc4166bf763d28d361a9#diff-73e8e7ae57dcf21616bd61f7eac8e8190db171f06e1f908cd7ae724b95b9c379
from bootstrap.native.
Let me finish updating the tests and I'll see what I can do. Meanwhile let me know what you think regarding:
- where you think the
inserted
event should trigger? I think anupdated
event would work better since it triggers on bothinserted
andupdated
, in fact it might be just to add to ourupdate
prototype methodupdate () => { styleTip(this); /* trigger updated here */ }
- same question for Dropdown, similar context, however the dropdown menu is always in the DOM, so on
updated
would again work better.
What do you think?
from bootstrap.native.
We can use only an updated event. It should trigger after the position styles are applied and before the dom becomes visible.
from bootstrap.native.
@jcorporation I've implemented the feature, however I'm having problems with the Cypress testing suite. The same old fix one crap 2 more pop.
from bootstrap.native.
@thednp : notify me, as soon it can be tested
from bootstrap.native.
@jcorporation the implementation is live, since this morning. I still have some testing scripting to fix.
from bootstrap.native.
Great, I will test it.
from bootstrap.native.
Related Issues (20)
- modal.dispose can cause issues if used in hidden.bs.modal HOT 5
- dropdown not support autoclose attribute HOT 1
- tab issues HOT 8
- getInstance behavior change between v4.1 and v4.2? HOT 4
- Popover positioning within sidebar with position fixed HOT 10
- types location needs to be fixed in package.json HOT 1
- dorpdown not support foreach
- Issues with closing a dropdown HOT 4
- offcanvas toggle bottom HOT 3
- BSN 5.0 comes with full Typescript source HOT 1
- Navbar with off-canvas drawer is hidden by backdrop HOT 5
- Popover button HOT 3
- Replace Bootstrap 4 HOT 1
- Where are the bootstrap 4 docs? HOT 1
- about source code HOT 5
- Dropdown menu closes instantly if user clickes on a span element inside the triggering button HOT 6
- exception when `isEmptyAnchor` called with SVG <use> tag HOT 6
- Bootstrap 4 to BSN migration HOT 2
- Should not import the named export 'version' HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from bootstrap.native.