Code Monkey home page Code Monkey logo

Comments (6)

TheColorRed avatar TheColorRed commented on June 23, 2024

When I run that command in the terminal it takes a while. How long does it take for you to manually run the command artisan route:list --json?

from vscode-laravel-artisan.

mac-s-g avatar mac-s-g commented on June 23, 2024

thanks for the quick reply.
takes about a second running in the terminal. a little bit longer to see json in the output panel when i invoke the command with the extension.
the video is a little misleading. i've left those display panels open for extended periods of time (10 mins or so) and the display doesn't update.

from vscode-laravel-artisan.

AaronLil avatar AaronLil commented on June 23, 2024

This behavior is really annoying, especially when checking routes, as it keeps repeating to update the real-time listing.

I investigated, and the problem is in the Common.js at:

Output.showConsole();

This line of code forces the display of the output panel/channel for any message, and I believe the correct behavior should be to only open the panel for error messages (as it happens a few lines below) or something relevant to the command we are executing.

I made a pull request removing this line of code. But in my opinion, this option could be configurable if displaying logs is really important for the extension.

from vscode-laravel-artisan.

AaronLil avatar AaronLil commented on June 23, 2024

I just realized that this issue has nothing to do with the pull request I made, which only fixes the unnecessary display and focus gain of the output panel. Please disregard my previous message.

from vscode-laravel-artisan.

uwla avatar uwla commented on June 23, 2024

Here is a temporary workaround:

Modify the route/List file to the following:

this.subscription = this.observable.subscribe();
setTimeout(() => this.subscription.unsubscribe(), 2000); // add this line

Change the default observer time from 5000ms to 1000ms.This gives enough time to load the routes and will run php artisan route:list only once or twice before the subscription is cancelled by the timeout handler.

Also, if you don't like the Laravel Artisan panel from popping up, comment the outputConsole.show() in utils/Output.

Effectly, this workaround requires you to manually change the extension.
This is not the proper way to fix the undesirable behavior, but it does work.

from vscode-laravel-artisan.

github-actions avatar github-actions commented on June 23, 2024

Marking issue as stale since there has'nt been any activity recently.

from vscode-laravel-artisan.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.