Presentational and Container Components about react-native-boilerplate HOT 8 CLOSED

I think that the "sagas" and the "store" shouldn't be used outside the containers folder, if any container needed to use the functionality contained in a saga should dispatch an action. And if part of the store is needed it should be accessed using a selector.

I think that this separation would improve the scalability and isolation of each container, as well as the testibility (which I am preparing in another PR).

In summary, the containers communicate with the sagas through actions and data as parameters. And just that. They do not access the functions of the sagas directly.

And a container can be connected to any part of the store regardless of where it is located. But given a large application, for my point of view, I prefer to have separate parts of the store on each container in order to have better organization, I do not think it improves anything of the code. It is simply organization.

Thank you for taking the time to review my proposal!.

from react-native-boilerplate.

Thank you very much for your hard work.
I will analyze your PR and give you a feedback soon.

from react-native-boilerplate.

Hi @alejandropaciotti ! After analyzing your issue and your MR, we agree with you on the fact that we need to add a Screen folder in order to separate containers and presentational components. But for the refactoring of Saga and Store folders, we do not agree, we want it outside of Container folder because multiple containers can call only one saga, so why putting it in a specific container?
What’s your opinion about that? 😃

from react-native-boilerplate.

btw, I've the code ready for a PR.

from react-native-boilerplate.

In summary, the containers communicate with the sagas through actions and data as parameters. And just that. They do not access the functions of the sagas directly.

100% agree and that what we do

I think that the "sagas" and the "store" shouldn't be used outside the containers folder, if any container needed to use the functionality contained in a saga should dispatch an action. And if part of the store is needed it should be accessed using a selector.

What if a container calls an action of another container? You’ll need to duplicate your action, right? So, if you have 5 screens which have to display the temperature (for example), you’ll do 5 actions (one for each screen) which call the same saga?

from react-native-boilerplate.

Yes, this is the price of having everything modularized.
It is the price of a container being contained in a folder.

But, in the hypothetical case that we have 5 screens that need to call an action, I think those containers should be contained in a parent container. And pass the function from parent to child, or maybe we should think a HOC to share that functionality.

from react-native-boilerplate.

We’ve thought about that and for a first version, we want to keep saga away from containers. But we’re really happy about your PR and we want to keep the idea of Screen folder. Thank you for your really interesting contribution ! Hope it will continue 😉

from react-native-boilerplate.

Of course I'll continue collaborating! And I understand your point of view, my change has pro, but also has cons.

We could close this issue and keep the interesting conversation that opened up, which certainly contributed more to me than to the repo.

from react-native-boilerplate.