Fibonacci numbers about c-plus-plus HOT 8 CLOSED

Hi @naveenyadav15 Can you be more specific with the issue?? It's working fine for me and giving a correct output. Fibonacci sequence is defined in 2 ways. One starts with 0 and 1. Other starts with 1 and 1.
Both these sequences are correct. If this resolves the issue, please check.

from c-plus-plus.

Like, if your input is 50 it is giving wrong answer(negative)

from c-plus-plus.

@naveenyadav15 i checked the code again. The problem is that the number at 48 is greater than the upper limit of a signed int, i.e., 2,147,483,647. So, the code breaks at the input greater than 47.

from c-plus-plus.

Okay, then we can correct it by using long long.

from c-plus-plus.

For larger number we can implement it with different data structure so that there would be no problem with size of data-type. @sachinarora707 if required I can work on that.

from c-plus-plus.

@naveenyadav15 Using unsigned long long int would improve it. But, it would still not work for very big numbers. For higher inputs, the code will break again.

from c-plus-plus.

@Balance-Breaker Sure, work on the issue.

from c-plus-plus.

I fixed the issue. I changed the datatype from int to long long.
This datatype can be overflow, too. But we increase the max limit.

from c-plus-plus.