Comments (2)
The test is alright. The snapshot is only saying that you passed an additional onClick function to your button. If that's okay with you, you only need to acknowledge it.
from hackernews-client.
Maybe that is the confusing part, why the snapshot fail? that will apear when I add on the App.js
Button.propTypes = { onClick: PropTypes.func.isRequired, className: PropTypes.string, children: PropTypes.node.isRequired, };
And in the test
test('has a valid snapshot', () => { const component = renderer.create( <Button onClick={() => {}} >Give Me More</Button> //this fail //<Button>Give Me More</Button> //old, this works ); const tree = component.toJSON(); expect(tree).toMatchSnapshot(); });
I can't understand why if I passing the "function" the snapshot fail.
Anyway thanks for your support
from hackernews-client.
Related Issues (7)
- Setting state directly in componentDidMount HOT 1
- Use of outline: none [accessibility] HOT 2
- Include use of <label> inside <form> [improved UX] HOT 5
- Wrong Links at the end of Error Handling section in Chapter 3 HOT 5
- Snapshot test fails if we don't use isomorphic-fetch HOT 7
- UnhandledPromiseRejectionWarning on Node 7.7.2 Bug HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from hackernews-client.