feature request: exit with non-zero code upon validation errors about istanbul-badges-readme HOT 20 CLOSED

Works on my end too. Thank you @olavoparno and @micalevisk 🎉 🥳

from istanbul-badges-readme.

I'm not sure if I'm using the flag correctly (or understood it correctly), but it always fails:

> istanbul-badges-readme --logo='jest' "--ci" "--exitCode=1"

Istanbul Badges Readme process started
Config check process started
- Readme file exists... ✔️.
- Coverage file exists... ✔️.
- Coverage hashes exist... ✔️.
- Readme hashes exist... ✔️.
Config check process ended
Editor process started
- Getting readme hashes...
- Getting new readme data...
- Getting coverage badge url for statements...
- Writing new readme data...
Editor process ended
Istanbul Badges Readme process finished
Error: Process completed with exit code 1.

from istanbul-badges-readme.

@myknbani and @micalevisk there is indeed a bug. Thank you @myknbani for testing it. @micalevisk do you want to open a PR fixing it or shall I do so? Thank you too for your support by the way, I really appreciate it :)

from istanbul-badges-readme.

@olavoparno

it is working as expected now. ty for the quick release!

from istanbul-badges-readme.

Hello @micalevisk thanks for opening the issue. Yeah, I think it was a bad design decision, indeed, I think I forgot to throw the error after logging them, so now we have to deal this behavior haha

I will look into your suggestion! Thank you once again :)

from istanbul-badges-readme.

@olavoparno sure. Should I add --exit-code optional flag?

from istanbul-badges-readme.

Yes, I think this is fine. If there's an explanation in the docs I think people will understand :) thank you, really.

from istanbul-badges-readme.

@micalevisk hello again! Sorry for the dalay, I was caught up with other things :( oh man, I took advantage of your WIP commit and I have already commited to the develop branch a version of exitCode. Sorry for your work, but I think it accomplishes the same thing as I think I got your idea.

from istanbul-badges-readme.

@olavoparno

I've put up a pull request to add @micalevisk! 🎉

from istanbul-badges-readme.

Please do take a look at version 1.8.0 https://www.npmjs.com/package/istanbul-badges-readme/v/1.8.0

Once again, thanks for the patience, mister @micalevisk

from istanbul-badges-readme.

@micalevisk is fast 😅

from istanbul-badges-readme.

@micalevisk hello again, sir, I am not having lots of spare time right now, would you mind opening a PR? If not, it's ok, I will try to do ASAP.

from istanbul-badges-readme.

btw I saw that other flags are following camel case then I've chose --exitCode instead 😄

from istanbul-badges-readme.

@all-contributors please add @micalevisk for idea, code, bug

from istanbul-badges-readme.

after running this, what's the output of echo $??

from istanbul-badges-readme.

nvm. You're right. I just tested it. This is a bug

from istanbul-badges-readme.

Also digging through the source code, it seems to just obey --exitCode=whatever all the time 😰

from istanbul-badges-readme.

@Could you guys test it again https://www.npmjs.com/package/istanbul-badges-readme/v/1.8.1?

Thank you both for the help as always.

from istanbul-badges-readme.

@all-contributors please add @myknbani for bug

from istanbul-badges-readme.

@olavoparno

I've put up a pull request to add @myknbani! 🎉

from istanbul-badges-readme.