Query Stats Returned with query including query bytes fetched about thanos HOT 5 OPEN

Please see https://github.com/thanos-io/promql-engine/pull/325/files and others for a previous attempt at this. We either want to have an improved Select() interface or pass these hints through context.Context somehow.

from thanos.

Hi @GiedriusS thanks so much for the pointer, do you know why it is not merged into upstream?

from thanos.

There are still some missing things: https://github.com/thanos-io/promql-engine/pull/325/files#diff-5b6024dfabe0bc120c9efaad778c55c7283d643c0ad2882eb7e47effa7aac384R24. Also, that PR needs some tests.

There was also a suggestion to just pass Select() metadata through context.Context. Perhaps it could be a simple map[string]any underneath with some getters/setters. Maybe it would be simpler to implement compared to that PR?

from thanos.

Yep, you could consider passing a function into ctx so no need to disrupt the query engine itself, reference about how M3 does that:

https://github.com/databricks/m3/blob/db_main/src/query/api/v1/handler/prom/read.go#L270-L278

and

https://github.com/databricks/m3/blob/db_main/src/query/api/v1/handler/prometheus/handleroptions/headers.go#L121-L123

from thanos.

published a PR here: #7390

from thanos.