Code Monkey home page Code Monkey logo

Comments (7)

Thalhammer avatar Thalhammer commented on July 21, 2024 1

@jfinkhaeuser Of course it should be fixed to error out. But since this is not a hard bug I will fix it once I come around to do so and consider it an improvement.

from jwt-cpp.

Thalhammer avatar Thalhammer commented on July 21, 2024 1

@jfinkhaeuser
I believe it should no behave correctly. You may check over it though.

from jwt-cpp.

Thalhammer avatar Thalhammer commented on July 21, 2024

Sorry for the late reply.
If I understand correctly, the "bug" is that the library does not protect you against using the wrong input key ?
Or is there also an issue if you use it correctly ?

from jwt-cpp.

jfinkhaeuser avatar jfinkhaeuser commented on July 21, 2024

The bug is in the invalid padding. The trigger are the mismatching keys.

from jwt-cpp.

Thalhammer avatar Thalhammer commented on July 21, 2024

Yeah but the bug regarding invalid padding was fixed in the other issue. So this is only about it not complaining about the user doing something wrong?

from jwt-cpp.

jfinkhaeuser avatar jfinkhaeuser commented on July 21, 2024

The code or the documentation.

I'm not trying to tell you what you should do, mind you. But I also have a quality management background, and my preference is that invalid inputs should not look like they succeed. Currently that's the case.

Personal preference would be to error out and document how to avoid it.

from jwt-cpp.

Thalhammer avatar Thalhammer commented on July 21, 2024

Behaviour should be fixed by fae2875.

from jwt-cpp.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.