Comments (6)
Fixed by tgstation/icon-cutter#11
from icondiffbot.
Still reproduces in a re-ran check, so it's not completely transient: https://github.com/goonstation/goonstation/pull/7226/checks?check_run_id=4877898512
from icondiffbot.
walls_ancient.dmi and walls_cave.dmi (walls_overgrown is fine) as of that commit has metadata that begins like:
# BEGIN DMI
version =
width = 32
height = 32
when it should look like:
# BEGIN DMI
version = 4.0
width = 32
height = 32
Probably IconDiffBot should not crash here, and anyways should not be using System.Version
to represent this field, which is not "the version number of an assembly, operating system, or the common language runtime".
from icondiffbot.
Interesting, those were both created with Dream Maker, so I blame DM for generating a malformed file.
I'd definitely argue it shouldn't crash and default to 4, especially if the program is liable to omit such information.
from icondiffbot.
I've been running into the same issue on wall-nerds/wallening#83 .
I saw that the /tg/ cutting tool that we were using for this (Which apparently also runs into the same issue with tables as it does with walls!) wasn't adding the version variable as an argument. However, by manually adding that version 4.0 to the file through tweakPNG, it now claims that all of those files are now out of date... AND still can't be read by icondiffbot! Except for the pizza walls, for some reason.
icerock_wall.zip
I don't know how much of it is my end and how much of it is from trying to force a solution, but I found this issue now after working on this for about an hour.
from icondiffbot.
walls_ancient.dmi and walls_cave.dmi (walls_overgrown is fine) as of that commit has metadata that begins like:
# BEGIN DMI version = width = 32 height = 32
when it should look like:
# BEGIN DMI version = 4.0 width = 32 height = 32
Probably IconDiffBot should not crash here, and anyways should not be using
System.Version
to represent this field, which is not "the version number of an assembly, operating system, or the common language runtime".
Ran into an extremely similar issue when doing PR #69147, but tweakpng seems to have fixed it. Unfortunately for Arcane's case, doing so did not fix his.
from icondiffbot.
Related Issues (20)
- Rendering icons in the root directory will always fail
- Stray white pixel in animated preview HOT 9
- Only 65535 characters are allowed; 186882 were supplied. HOT 2
- Icon diffs reportedly taking 2017 years to complete HOT 2
- Modifying the default icon state breaks table
- Deleting empty icon files breaks
- Error generating diffs HOT 5
- No 404 page HOT 2
- The located assembly's manifest definition does not match the assembly reference HOT 1
- System.IO.FileLoadException HOT 3
- Per-repository rate limiting
- Octokit.AuthorizationException: Bad credentials HOT 5
- Diffs generating for over an hour HOT 8
- API route for blacklisted codebases
- Microsoft.EntityFrameworkCore.DbUpdateException HOT 2
- Octokit.ApiException: An error occurred with this API request
- MySql.Data.MySqlClient.MySqlException (0x80004005): Connect Timeout expired.
- icondiffbot running forever
- Feature Request: 1 alpha pixel highlighting
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from icondiffbot.