Code Monkey home page Code Monkey logo

Comments (3)

tgolsson avatar tgolsson commented on June 12, 2024 1

Hmm, interesting! I think this is mostly a display issue, will have to look more closely. Pants makes some assumptions about fields being (somewhat) unique -- in particular, that there is only one Dependencies field etc. Some of my targets have two, because I think the UX of a separate field for the "base" image is preferrable. I've not noticed any adverse effects in practice, but I hadn't considered this aspect.

from pants-backends.

jgranstrom avatar jgranstrom commented on June 12, 2024

It's the same in the examples in this repo:

pants-backends main
 ❯ pants dependencies //examples/oci:oci
examples/oci:python3-d11#latest

 ❯ pants peek //examples/oci:oci
[
  {
    "address": "examples/oci:oci",
    "target_type": "oci_image_build",
    "args": null,
    "base": [
      ":python3-d11#latest"
    ],
    "commands": null,
    "dependencies": [
      "examples/oci:python3-d11#latest"
    ],
    "description": null,
    "entrypoint": null,
    "env": null,
    "layers_raw": null,
    "output_path": null,
    "packages_raw": [
      ":example"
    ],
    "repository": "harbor.sbg.dev/test/pants-plugin-oci-example",
    "tag": "latest",
    "tags": null,
    "terminal": false
  }
]

How does it know when it needs to rebuild the image when the pex is rebuilt? Do you pick that out manually, or just run everything?

from pants-backends.

jgranstrom avatar jgranstrom commented on June 12, 2024

Hmm, interesting! I think this is mostly a display issue, will have to look more closely. Pants makes some assumptions about fields being (somewhat) unique -- in particular, that there is only one Dependencies field etc. Some of my targets have two, because I think the UX of a separate field for the "base" image is preferrable. I've not noticed any adverse effects in practice, but I hadn't considered this aspect.

FYI I worked around this for my case by using oci_layer, putting the packages in there and adding that instead to oci_image_build, then everything behaves as expected with dependencies.

from pants-backends.

Related Issues (17)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.