Delegate work out of services to repositories about typescript-typeorm-realworld-example-app HOT 8 CLOSED

Hi @tgiardina I want to work on this

from typescript-typeorm-realworld-example-app.

@kunwar97 Excellent, it's all yours! I think TypeOrm will do most of the work for you. The roadmap probably looks something like:

1. Delete services/user .
2. Refactor controllers/user to use IUserRepository instead of IUserService.
3. Refactor loaders/container as appropriate.

Let me know if you have any questions!

from typescript-typeorm-realworld-example-app.

Sure

from typescript-typeorm-realworld-example-app.

@tgiardina What about tests in services/user. Should I delete them or move them to another folder?

from typescript-typeorm-realworld-example-app.

@kunwar97 I think it's fine if you delete them. TypeORM should do everything for you, and there's no need to test that their save and findOne methods are working correctly.

Feel free to get rid of result and all references to it too. I added it as a helper because I was used to Rust, but it's just making the code more complicated at this point.

from typescript-typeorm-realworld-example-app.

@tgiardina #30

from typescript-typeorm-realworld-example-app.

@kunwar97 Thanks! I'll check it out later today!

from typescript-typeorm-realworld-example-app.

#30 resolved this issue.

from typescript-typeorm-realworld-example-app.