Comments (4)
rodrigogiraoserrao
commented on June 7, 2024
Hey @jrycw, thanks for opening this issue!
We represent BitSwitch.value with a switch because bits are commonly thought of in terms of on/off, like you said, but BitSwitch.value is the value of the binary expansion of the number in that bit, so it makes sense to keep it as an integer.
I'll go through the example to make sure it's clear when we're working with integers vs Booleans.
As for the event accepting the bit and value parameters, I believe the author of that guide added them because those are sensible things to include in that sort of message...
But it may be confusing for people reading the code because they can't see those parameters being used...
Point taken.
from textual.
rodrigogiraoserrao
commented on June 7, 2024
Apparently the remainder of the code also thinks BitSwitch.value is a Boolean, so I'll go with your suggestion!
from textual.
rodrigogiraoserrao
commented on June 7, 2024
See the PR linked above for the resolution of this issue.
from textual.
github-actions
commented on June 7, 2024
Don't forget to star the repository!
Follow @textualizeio for Textual updates.
from textual.
Related Issues (20)
- `DirectoryTree.clear_node` doesn't actually clear the node HOT 1
- Select widget "disabled" HOT 1
- Add `remove` attribute to `mount` and `mount_all` HOT 7
- Add a `lock` to every widget. HOT 3
- Clarify `Input` docs about removing spacing HOT 1
- Input widgets error when I configure type arguments
- A Widget with {margin: 1} style in a ScrollableContainer causes infinite resizes and scrollbars flicker HOT 7
- Pilot cannot click switch with horizontally aligned, long text HOT 5
- Clarify `is_end_of_document_line` in docs HOT 6
- Omitting TextArea theme doesn't highlight
- TabbedContent active attribute doesn't post message TabActivated + doesn't arrange tabs HOT 5
- TextArea crashes Python on html language HOT 5
- Blank display on AIX HOT 10
- check error in the "textual colors" app HOT 7
- Search Functionality for the Select Widget HOT 5
- No display on non-UTF8 locale HOT 1
- Tab scrolling not working HOT 5
- No Tcss file included in documentation for On_decorator example HOT 3
- Stop `TextArea` cursor moving beyond end of line in `read_only` mode? HOT 1
- Event documentation doubles up the bubble and verbose checkboxes HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from textual.