Code Monkey home page Code Monkey logo

Comments (5)

infininight avatar infininight commented on July 27, 2024

Two things are at play here:

MathJax is not part of the markdown spec so excluding them from italics can't happen by default. This bundle only supports the base markdown, the MathJax bundle could add a match for the blocks and exclude italics inside them if desired.

The example provided does not happen with the grammar from this bundle, we require an ending to the italics exist on the same line. The grammar at fault here is in the Markdown (Github) bundle which is more permissive about where italics are allowed.

from markdown.tmbundle.

noniq avatar noniq commented on July 27, 2024

This might have been already fixed in the Github Markdown bundle, see textmate/GitHub-Markdown.tmbundle#21

from markdown.tmbundle.

fonnesbeck avatar fonnesbeck commented on July 27, 2024

@noniq Thanks for that. I will check it out.

from markdown.tmbundle.

infininight avatar infininight commented on July 27, 2024

@fonnesbeck I had missed the @noniq pull request being accepted so my bundle was outdated and I hadn't deployed this change. However it did not actually solve the issue due to some interactions with the rule and the standard italics rule. I've made a new pull request at textmate/GitHub-Markdown.tmbundle#24 which contains some fixes and somewhat improves your use case. It will still match in an undesired fashion but will no longer extend outside the current line. It could also be confused by two MathJax strings on the same line but would still not persist the error past the line.

from markdown.tmbundle.

fonnesbeck avatar fonnesbeck commented on July 27, 2024

@infininight Thanks, I will test the new PR, which I see is already merged.

from markdown.tmbundle.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.