Words containing two underscores break highlighting of rest of document about github-markdown.tmbundle HOT 6 CLOSED

I can't find an official description but the original intent was to provide this additional feature that GitHub Flavoured Markdown provides:

Escape Underscores in Words

It is not reasonable to italicize just part of a word, therefore words containing multiple underscores have their inner underscores escaped. This foo_bar_baz does not turn into foobarbaz.

https://www.drupal.org/project/gfm

from github-markdown.tmbundle.

Makes sense. But it seems that TextMate's own Markdown grammar already handles this (see second screenshot)?

from github-markdown.tmbundle.

@noniq Yes, you are correct. 👍 to tearing out the new buggy, italic stuff from me.

from github-markdown.tmbundle.

Hm okay, not sure what exactly I did wrong, but TextMate’s own Markdown grammar does indeed italicize part of words. So it is still necessary to somehow override this feature in this bundle.

I’m right now experimenting a bit, the following seems to work fine:

I simplified the look-behind pattern to make sure the rule also matches the first underscore in a word. I also changed the injection selector to (L:text.html.markdown) (removing the markup.italic.markdown part). Finally, I changed name to markup.other to prevent the matched underscores from getting italicized (which does not make a different in any font I know of, but who knows …)

I’ve checked with a few Markdown documents, and they all seem to be highlighted correctly. But I’m totally sure that there could be some edge cases where something breaks. Any ideas what else to check or improve?

from github-markdown.tmbundle.

I’ve checked with a few Markdown documents, and they all seem to be highlighted correctly. But I’m totally sure that there could be some edge cases where something breaks. Any ideas what else to check or improve?

Seems great to me; definitely better than what's there currently!

from github-markdown.tmbundle.

I merged this for now. I’ll keep an eye on it and refine if necessary.

from github-markdown.tmbundle.