Code Monkey home page Code Monkey logo

Comments (3)

worldspawn avatar worldspawn commented on May 27, 2024

Also line 389, every where else items off scope are access via scope.xxx but here it use this.xxx which failed in my strict uglify output. Changing it to:

if (scope.bUpdateSelectedStyles) $timeout(scope.updateSelectedStyles, 200); // used to update the active state when a key is held down, ie the left arrow

fixed it

from textangular.

SimeonC avatar SimeonC commented on May 27, 2024

Thanks for the information, I've updated this in other commits. For reference could you tell me what uglifier and settings do you use please?

from textangular.

worldspawn avatar worldspawn commented on May 27, 2024

Sure, I'm using grunt-contrib-uglifier - https://github.com/gruntjs/grunt-contrib-uglify.

My settings i was using had beautify on and mangle off. Defaults for the rest.

My own scripts have 'use strict' in them, uglifier seem to move that declaration to the top of the output file thus making all the scripts included be processed as strict. Its not really an uglifier issue, its just that uglifier helped bring it to my attention.

from textangular.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.