Proxy-Wasm extension out of memory about proxy-wasm-go-sdk HOT 4 CLOSED

@fzy-Line Could you please provide me the followings for detail ?

• The version or commit hash of this SDK
• The extension's code
• The configuration yaml of Envoy
• The version of Envoy (Envoy or Istio/proxyv2) and it's commit hash

FWIW, #86 resolved some memory leak issue.

from proxy-wasm-go-sdk.

BTW, there's no way to grow VM's maximum memory from user program side. The "grow" instruction (https://webassembly.github.io/spec/core/syntax/instructions.html#syntax-instr-memory) should be inserted in in the compiled binary by your compilers and developers shouldn't care about that.

from proxy-wasm-go-sdk.

I found the cause of the OOM. It doesn't looks like an proxy-wasm extension problem, but a problem of my code implementation. In golang, the map will not release memory after deleting elements. In my extension's code, I use a global map to share context:

var records map[uint32]*RequestInfo

func saveRequestInfo(key uint32, requestInfo *RequestInfo){
	mutex.Lock()
	defer mutex.Unlock()
	records[key] = requestInfo
}

func (ctx *httpHeaders) OnHttpRequestHeaders(numHeaders int, endOfStream bool) types.Action {

	requestInfo := new(RequestInfo)

	// Get info from http head and set to requestInfo
	// ......

	// put requestInfo to map
	saveRequestInfo(ctx.contextID, requestInfo)

	return types.ActionContinue
}


func (ctx *httpHeaders) OnHttpResponseHeaders(numHeaders int, endOfStream bool) types.Action {

	requestInfo := records[ctx.contextID]

	// use these info and send a httpcall
	// ......

	// delete map element
	delete(records, ctx.contextID)

	return types.ActionContinue
}

The reference: golang/go#20135

So I want to know if there is a better way to share context in Proxy-wasm extension.

from proxy-wasm-go-sdk.

why not just embed the info to fields in your httpHeaders struct? btw you do not need to have mutex anyway since Proxy-Wasm env is single-threaded.

from proxy-wasm-go-sdk.