Comments (2)
I would speculate that this might work:
In SubmissionResultHandler::showResultMessage
from src/main/java/fi/helsinki/cs/tmc/intellij/ui/submissionresult/SubmissionResultHandler.java
:
public void showResultMessage(Exercise exercise, SubmissionResult result, Project project) {
logger.info("Showing submission result message. @SubmissionResultHandler");
- if (result.isAllTestsPassed()) {
+ if (result.isAllTestsPassed() && !result.validationsFailed()) {
new SuccessfulSubmissionDialog(exercise, result, project);
} else {
new FailedSubmissionDialog(result, project);
}
}
FailedSubmissionDialog
would also need to be updated to actually show the failed validations.
from tmc-intellij.
Nevermind, looks like this is either an issue in the tmc-core.
2016-11-28 20:12:56 DEBUG AbstractSubmissionCommand:78 - Server done, parsing results
2016-11-28 20:12:56 INFO CoreProgressObserver:28 - Setting progress status. @CoreProgressObserver
2016-11-28 20:12:56 WARN SubmissionResultParser:68 - Failed to parse submission result
com.google.gson.JsonSyntaxException: java.lang.IllegalStateException: Expected BEGIN_OBJECT but was STRING at line 1 column 245 path $.validations.validationErrors.
at com.google.gson.internal.bind.ReflectiveTypeAdapterFactory$Adapter.read(ReflectiveTypeAdapterFactory.java:200)
at com.google.gson.internal.bind.TypeAdapterRuntimeTypeWrapper.read(TypeAdapterRuntimeTypeWrapper.java:40)
at com.google.gson.internal.bind.MapTypeAdapterFactory$Adapter.read(MapTypeAdapterFactory.java:186)
at com.google.gson.internal.bind.MapTypeAdapterFactory$Adapter.read(MapTypeAdapterFactory.java:145)
at com.google.gson.internal.bind.ReflectiveTypeAdapterFactory$1.read(ReflectiveTypeAdapterFactory.java:103)
at com.google.gson.internal.bind.ReflectiveTypeAdapterFactory$Adapter.read(ReflectiveTypeAdapterFactory.java:196)
at com.google.gson.internal.bind.ReflectiveTypeAdapterFactory$1.read(ReflectiveTypeAdapterFactory.java:103)
at com.google.gson.internal.bind.ReflectiveTypeAdapterFactory$Adapter.read(ReflectiveTypeAdapterFactory.java:196)
at com.google.gson.Gson.fromJson(Gson.java:810)
at com.google.gson.Gson.fromJson(Gson.java:775)
at com.google.gson.Gson.fromJson(Gson.java:724)
at com.google.gson.Gson.fromJson(Gson.java:696)
at fi.helsinki.cs.tmc.core.communication.serialization.SubmissionResultParser.parseFromJson(SubmissionResultParser.java:53)
at fi.helsinki.cs.tmc.core.commands.Submit.call(Submit.java:82)
at fi.helsinki.cs.tmc.core.commands.Submit.call(Submit.java:23)
at fi.helsinki.cs.tmc.intellij.services.exercises.ExerciseUploadingService.getSubmissionResult(ExerciseUploadingService.java:112)
at fi.helsinki.cs.tmc.intellij.services.exercises.ExerciseUploadingService.access$000(ExerciseUploadingService.java:25)
at fi.helsinki.cs.tmc.intellij.services.exercises.ExerciseUploadingService$1.run(ExerciseUploadingService.java:86)
at com.intellij.openapi.progress.impl.CoreProgressManager$3.run(CoreProgressManager.java:179)
at com.intellij.openapi.progress.impl.CoreProgressManager.a(CoreProgressManager.java:568)
at com.intellij.openapi.progress.impl.CoreProgressManager.executeProcessUnderProgress(CoreProgressManager.java:519)
at com.intellij.openapi.progress.impl.ProgressManagerImpl.executeProcessUnderProgress(ProgressManagerImpl.java:54)
at com.intellij.openapi.progress.impl.CoreProgressManager.runProcess(CoreProgressManager.java:164)
at fi.helsinki.cs.tmc.intellij.services.ThreadingService$1.run(ThreadingService.java:23)
at com.intellij.openapi.application.impl.ApplicationImpl$2.run(ApplicationImpl.java:309)
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
at java.lang.Thread.run(Thread.java:745)
Caused by: java.lang.IllegalStateException: Expected BEGIN_OBJECT but was STRING at line 1 column 245 path $.validations.validationErrors.
at com.google.gson.stream.JsonReader.beginObject(JsonReader.java:387)
at com.google.gson.internal.bind.ReflectiveTypeAdapterFactory$Adapter.read(ReflectiveTypeAdapterFactory.java:189)
... 29 more
2016-11-28 20:12:56 INFO CoreProgressObserver:28 - Setting progress status. @CoreProgressObserver
2016-11-28 20:12:56 WARN AbstractSubmissionCommand:91 - Error while updating submission status from server, continuing
from tmc-intellij.
Related Issues (20)
- Not able to use TMC plugin HOT 2
- UninitializedHolderException when selecting course
- Error when running local tests HOT 2
- NullPointerException when pressing button for next exercise HOT 4
- "Download course exercises" failed with error message on first attempt. Subsequent attempts fails silently HOT 1
- Mac ( High Sierra) Not Downloading Courses
- TMC for IntelliJ on mac doesn't work at all
- The colour green in Test Results bar is way too bright
- NullPointerException on pressing run test for current project
- IDE Fatal Error when Running test HOT 3
- PLEASE add support for newest IntelliJ
- Using version 2.0.2 tests fail to run HOT 2
- intellij TMC Plugin error
- IntelliJ plug in errors
- java.lang.NullPointerException
- IDE Fatal Error. Java.lang.NullPointer Exception HOT 2
- "Run tests for current project" isn't working
- Getting a nullpointer exception when trying to submit an exercise
- Cannot process toolwindow TMC Project List
- Plugin fails to start on IntelliJ 2022.2.3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from tmc-intellij.