Code Monkey home page Code Monkey logo

Comments (5)

wKovacs64 avatar wKovacs64 commented on July 17, 2024 1

Yeah, I was mistakenly trying to run your validate script in react-testing-library on Node 6. Sorry for the confusion, lack of sleep and running on fumes today. 😄

from react-testing-library.

kentcdodds avatar kentcdodds commented on July 17, 2024

I'd be fine with 6. But why don't you upgrade to 8?

from react-testing-library.

wKovacs64 avatar wKovacs64 commented on July 17, 2024

In this particular case, I could, as Netlify provides a way to do that and I don't care about the Node version for my app. But I'd imagine scenarios exist where that's not possible, either due to lack of control of the runtime environment or app-specific target requirements or what-have-you. It seems like an odd and unexpected developer experience to require runtime environment changes to use such a small testing library when there's no underlying technical reason for it.

6 makes sense, I'll send a PR for it. Thanks!

from react-testing-library.

wKovacs64 avatar wKovacs64 commented on July 17, 2024

Oh. Just noticed kcd-scripts uses Object.entries. Thoughts? Maybe this truly does require Node 8.

from react-testing-library.

kentcdodds avatar kentcdodds commented on July 17, 2024

kcd-scripts shouldn't make any difference for whether you can use this library. This library doesn't depend on kcd-scripts (except as a dev dependency, which you shouldn't need to install). Now if you're using kcd-scripts yourself, then yes, you'll have to use Node 8. That will never support less than Node 8.

from react-testing-library.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.