Unexpected behavior when minifying HTML containing SVG about html-minifier-terser HOT 5 CLOSED

Related issue: kangax/html-minifier#1092.

from html-minifier-terser.

Since this is documented, can be tested on https://terser.org/html-minifier-terser/ and there is also a way to prevent all optimizations (https://github.com/terser/html-minifier-terser#ignoring-chunks-of-markup) I'm closing this issue.

There are good reasons why all optimizations are disabled by default and why this is in red:

from html-minifier-terser.

Ignoring chunks of markup is fine, so long as you are authoring the HTML in question. Otherwise, one needs to dynamically modify the received markup in order to preserve empty elements in SVG.

from html-minifier-terser.

True. Normally this is done in webpack setups with the right plugins which replace texts or before compilation using sed or other solutions.

In general this case is currently not covered by the tests as it is not recommended to enable removeEmptyElements since this can break and will break things.

So far only html elements are not affected by this:

https://github.com/terser/html-minifier-terser/blob/v6.0.2/src/htmlminifier.js#L429
https://github.com/terser/html-minifier-terser/blob/v6.0.2/src/htmlminifier.js#L1134
https://github.com/terser/html-minifier-terser/blob/v6.0.2/src/htmlminifier.js#L517-L545

I'm not sure if it makes sense to add svg and xml elements to this function by default but this could lead to the case, that we will have to add many more tags to this function to prevent such issues and that this has to be correctly tested.

But as this is marked as red / breaking, I'm opting for keeping as it is and removing the option from the CLI like you already did.

If this is not in your interest, you may want to check https://github.com/tdewolff/minify#html

https://go.tacodewolff.nl/minify

from html-minifier-terser.

Thanks for the details and links. :)

from html-minifier-terser.