Comments (6)
Hi @97carmine,
it seems you use the new plug and play feature of yarn which reports this:
terser tried to access acorn, but it isn't declared in its dependencies; this makes the require call ambiguous and unsound.
Please report this error in the repo of the affected package which is terser
itself so they can fix this.
https://github.com/terser/terser/issues
I can see acorn
at https://github.com/terser/terser/blob/master/package.json#L52 so maybe it has to be moved to the normal dependencies.
Alternatively you can disable the pnp feature of yarn which will apply the legacy behavior or you can use npm.
from html-minifier-terser.
I couldn't seem to find a submitted issue on terser so I submitted one: terser/terser#1076
Should this issue remain open in the meantime? Even though the source of the issue is in terser, once it's fixed there, the dependency would have to be bumped in this package. A package breaking Yarn PnP builds is a fairly rare occurrence nowadays. I'll track both issues and hopefully, this can be resolved soon.
from html-minifier-terser.
For anyone who needs a quick fix in the meantime, v5.1.1
of html-minifier-terser
is not affected by this issue.
from html-minifier-terser.
This issue here can stay closed since the consumers of html-minifier-terser will receive minor and patch releases of terser.
See also https://github.com/terser/html-minifier-terser/blob/master/package.json#L73
^5.8.0
will pick up any 5.x
release.
from html-minifier-terser.
Terser doesn't depend on Acorn unless it is instructed to parse with Acorn - https://github.com/terser/terser#use-acorn-for-parsing - and so it shouldn't be a prod dependency.
Is Yarn trying to aggressively follow dependencies wherever it sees a require()
? If there's a code comment or something that can be placed next to the require()
that tells it not to do that, it would be neighborly of Terser to add that. But AFAICT Terser is doing nothing wrong.
from html-minifier-terser.
We should keep the discussion in one place.
Since this is a problem with terser, I have replied at terser/terser#1076 (comment)
Locking this issue since any further replies here should belong to the issue at terser/terser#1076
from html-minifier-terser.
Related Issues (20)
- [Bug]: JUST FULLY ERR! HOT 4
- Minify JSON-LD HOT 4
- Upgrade `clean-css` To `v5.3`
- Remove some legacy things? HOT 1
- [Bug]: `<!--#-->` comments are not removed
- [Feature request]: Preserve EOF newline for Unix file format
- Src included in build? HOT 2
- [Feature Request] Typescript types
- wrap each col element in a colgroup when render col in a separate function HOT 1
- [Bug]: Can't be used in the browser HOT 2
- <code> tag
- [Bug]: bug with ejs template engine
- Feature request: Option for adding comment/copyright/disclaimer text to source code HOT 2
- [Bug]: Remove redundant attributes should support <img> loading attribute
- Support <script type="importmap">
- [Bug]: engine field and workflow matrix could be updated
- [Bug]: Scripts minfiier has cloned variable names that crashes program when mange is activated HOT 3
- Please Consider `cssnano` Instead of `clean-css` HOT 3
- [Bug]: Error Minimizing JSON File HOT 1
- [Bug]: Nested CSS, parent is lost
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from html-minifier-terser.