Comments (4)
We have a similar issue in an Angular project, where multiple consecutive spaces get removed from our customAttrCollapse
attributes/directives despite having conservativeCollapse: true
in our options.
i.e.
alias="
foo as bar,
bar as foo,
reallyLongFoo as bar
"
becomes
alias="fooas bar, baras foo, reallyLongFoo as bar"
changing https://github.com/terser/html-minifier-terser/blob/v5.1.1/src/htmlminifier.js#L328 to be
attrValue = trimWhitespace(attrValue.replace(/\n+|\r+/g, '').replace(/\s{2,}/g, options.conservativeCollapse ? ' ' : ''));
fixes our issue, but I'm not sure of the reasoning behind the \s{2,}
part of the regex in the first place as to whether this is a reasonable fix or not?
from html-minifier-terser.
Hi @xReeQz,
can you provide a full example code for the html-minifier-terser so we have a testcase and the options that you use?
https://github.com/terser/html-minifier-terser/blob/v5.1.1/src/htmlminifier.js#L327
from html-minifier-terser.
@DanielRuf here's an HTML sample:
<ui-select-choices
repeat="status in segment.statuses |
filter: {displayName: $select.search}
track by status.id"
>
<span class="tu-match"
ng-bind-html="status.displayName |
highlight: $select.search"
></span>
</ui-select-choices>
The options I use are:
{
caseSensitive: true,
collapseWhitespace: true,
conservativeCollapse: true,
keepClosingSlash: true,
minifyCSS: true,
minifyJS: true,
removeComments: true,
removeRedundantAttributes: true,
removeScriptTypeAttributes: true,
removeStyleLinkTypeAttributes: true,
customAttrCollapse: /(ng-class|messages|repeat)/
}
from html-minifier-terser.
Can you test if this would result in a green CI build? You can provide a PR and we can see then if there are any negative side-effects or not.
from html-minifier-terser.
Related Issues (20)
- [Bug]: JUST FULLY ERR! HOT 4
- Minify JSON-LD HOT 4
- Upgrade `clean-css` To `v5.3`
- Remove some legacy things? HOT 1
- [Bug]: `<!--#-->` comments are not removed
- [Feature request]: Preserve EOF newline for Unix file format
- Src included in build? HOT 2
- [Feature Request] Typescript types
- wrap each col element in a colgroup when render col in a separate function HOT 1
- [Bug]: Can't be used in the browser HOT 2
- <code> tag
- [Bug]: bug with ejs template engine
- Feature request: Option for adding comment/copyright/disclaimer text to source code HOT 2
- [Bug]: Remove redundant attributes should support <img> loading attribute
- Support <script type="importmap">
- [Bug]: engine field and workflow matrix could be updated
- [Bug]: Scripts minfiier has cloned variable names that crashes program when mange is activated HOT 3
- Please Consider `cssnano` Instead of `clean-css` HOT 3
- [Bug]: Error Minimizing JSON File HOT 1
- [Bug]: Nested CSS, parent is lost
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from html-minifier-terser.