Code Monkey home page Code Monkey logo

Comments (5)

codepunkt avatar codepunkt commented on June 1, 2024 6

It was neither obvious to me that this is the maintained solution, nor why using terser would be better.
You assume a lot of knowledge here that most developers will not have.

I specifically seached the issues and after reading this, will replace my current usage of html-minifier with this package.

I'd strongly suggest documenting this visibly in the README.

from html-minifier-terser.

DanielRuf avatar DanielRuf commented on June 1, 2024 3

Hi @yrtimiD,

the difference is that html-minifier-terser uses terser instead of uglify-js to support ES6 and newer.

See v4.0.0...master and kangax/html-minifier#1040 to understand the motivation behind this.

It has to do with the fact that the maintainer of html-minifier is also the maintainer of ugligy-js and he was not interested to move to terser which works (unlike uglify-es).

from html-minifier-terser.

DanielRuf avatar DanielRuf commented on June 1, 2024 2

Closing as obsolete as in my opinion the fork with terser is the current maintained solution and supports modern JavaScript. As terser was forked from uglify-es and the API is (mostly) the same there is not much to document.

See https://github.com/terser/terser#why-choose-terser

from html-minifier-terser.

yrtimiD avatar yrtimiD commented on June 1, 2024

Will be nice to have this explanation in the README.md

from html-minifier-terser.

DanielRuf avatar DanielRuf commented on June 1, 2024

I think the addition in the package name is sufficient.
It is a direct replacement.

PRs for the README.md file are very welcome.

from html-minifier-terser.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.