Code Monkey home page Code Monkey logo

Comments (2)

kentliau avatar kentliau commented on June 12, 2024

if you want a pull request from me, please tell me.

from fluidbox.

terrymun avatar terrymun commented on June 12, 2024

I am a bit ambivalent about implementing this fix. This only enables partial support for extraneous dimensions added by padding and/or border — if you look into your modified page you will see that the enlarged image is no longer properly centered. So this all boils down to an all or none support for additional widths and paddings applied to the images, the former of which I feel is tricky to implement, and unnecessarily bloating; the latter of which I feel might limit the extensibility and applicability of Fluidbox.

I am looking into implementing support for paddings and borders. Stay tuned.

[Update] This feature is implemented in the v1.3.2 release.

from fluidbox.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.