Comments (2)
if you want a pull request from me, please tell me.
from fluidbox.
I am a bit ambivalent about implementing this fix. This only enables partial support for extraneous dimensions added by padding and/or border — if you look into your modified page you will see that the enlarged image is no longer properly centered. So this all boils down to an all or none support for additional widths and paddings applied to the images, the former of which I feel is tricky to implement, and unnecessarily bloating; the latter of which I feel might limit the extensibility and applicability of Fluidbox.
I am looking into implementing support for paddings and borders. Stay tuned.
[Update] This feature is implemented in the v1.3.2 release.
from fluidbox.
Related Issues (20)
- Update max-width HOT 7
- Bootstrap's container is cropping the enlarged image HOT 1
- trigger('close.fluidbox') breaks re-opening HOT 5
- On Chrome: translate mispositioning HOT 3
- Navigate Fluidbox with Arrow Keys HOT 2
- Trouble installing HOT 5
- Blurry zoomed image on Safari HOT 11
- Scroll to close doesn't work like in Medium HOT 4
- help conflict with mcustomscrollbar HOT 2
- CSS workaround for differential aspect ratios? HOT 1
- It doesn't work within a container. HOT 4
- Update to latest version of jquery HOT 2
- Improve trigger on images with a different a.href HOT 1
- Image URLs containing a plus sign cause an "opening halted" warning
- Update debounce
- Prevent closing fluidbox in closestart event HOT 1
- Safari Still Rendering Blurry Images
- Cropped fluidbox inside block with overflow:hidden
- Getting Console Warning with debounce/throttle plugin
- Event names should be delimited by a space in jQuery.on
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from fluidbox.