Code Monkey home page Code Monkey logo

Comments (3)

AnaBelgun avatar AnaBelgun commented on June 10, 2024

from @meh9
Looks good to me.

Note that I usually use a random hash instead of your example of "dea_coastlines" above - otherwise when things are renamed people often get the urge to change the id as well, if it's a random hash then they usually leave it alone!

E.g. https://github.com/TerriaJS/aremi-natmap/blob/master/datasources/aremi/custodian/Geoscience_Australia/Bathymetry_Seabed.ejs#L2

from de-australia-map.

AnaBelgun avatar AnaBelgun commented on June 10, 2024

from Robbi
That's a good idea! Plus it would avoid needing to come up with/use some kind of consistent naming convention for those fields

from de-australia-map.

AnaBelgun avatar AnaBelgun commented on June 10, 2024

More comments on how share keys work:
So... if we kept the “ids” the same as they were originally but made changes to the “share keys”, will that break existing share links?
It might break really old ones. shareKeys should only ever be added to, and as soon as you add an id to that item you no longer need to keep adding to them. You can think of the shareKeys as a list of all the places an item has been before it was given an id.

from de-australia-map.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.