All Custom Block which do not copy their properties from Vanilla Blocks are missing their Tags about traverse HOT 12 CLOSED

If this fix is applied, for what versions would it be applied?

from traverse.

Could you be a bit more specific about what other mod(s) you are referring to? I'm not disbelieving the problem, it would just make it easier for me to find out what kinds of properties are missing.

from traverse.

After further investigation I think I have found the root of the bug. I think it is an issue with the Vanilla Tags which a lot of mods use to generally group item / block types. When an item / a block has the FabricBlockSettings.copyOf(Blocks.Vanilla_Block_Here) it seems to also copy the Tags, the blocks which do not use this setting, do not have their matching tags.

I was able to see this bug using the Create Mod. Crafting recipies involving planks worked fine because Fir Planks inherit from Oak Planks (Have the Plank Tag), whereas Crafting Recipies involving Stripped Logs did not work because they do not inherit from Stripped Oak Logs (Have the Stripped Log Tag)

Specific Crafting Recipies used: Crafting a Cogwheel ; Crafting an Andesite Casing

Note I think that the blocks behave more or less as they should, they are just missing these groupings to make them complete.

Hope this helps, AwesomeDude091

from traverse.

What version of Minecraft are you testing with and what version of Traverse / Terrestria?

from traverse.

I was testing on Version 1.19.2, latest build

from traverse.

To be more specific in the 1.20 version I think the issue is that some blocks do not inherit and in 1.19.2 the issue is that the stripped log inherits from FabricBlockSettings.copyOf(Blocks.OAK_LOG) not the STRIPPED_OAK_LOG

from traverse.

OK, the tag they are using is c:stripped_logs, which is not defined in Fabric's ConventionalItemTags even in the latest 1.20 versions. Generally we do not define conventional tags that are not included in Fabric. What I can do is add a few more one-off conventional tags, if you can give me a list of recipes you've noticed are not working. I would backport this change to 1.19.4 and 1.19 (which includes .1 and .2) but probably not to 1.19.3 which I consider largely abandoned.

from traverse.

I will investigate and report back :))

The one I can already confirm right now is Stripped Logs.

Thank you going out of your way to add this support :))

from traverse.

I see we also need c:stripped_wood and for bonus points could define c:stone (Terrestria's volcanic rock). Not an exhaustive check yet though; Create has a huge pile of recipes.

from traverse.

Stripped Logs were the only thing I could find, thank you so much. Also will this be added to Terrestria and Cinderscapes?

from traverse.

Also will this be added to Terrestria and Cinderscapes?

Yes.

from traverse.

Resolved in 6.0.7, 6.2.2, and 7.0.1.

from traverse.