Limit ALB SG ingress to GH only (via input variable) about terraform-aws-atlantis HOT 8 CLOSED

Thanks for adding the var @ldormoy!
@antonbabenko we could still do something like

"${concat(data.github_ip_ranges.this.hooks, var.alb_ingress_cidr_blocks)}"

in order to default var.alb_ingress_cidr_blocks to an empty list instead of ["0.0.0.0/0"] which may not be as secure...
PS: I'll consider addressing this issue a NYE resolution for 2019 :)

from terraform-aws-atlantis.

Agree, https://www.terraform.io/docs/providers/github/d/ip_ranges.html

from terraform-aws-atlantis.

Didn't know about that data source. Awesome ❤️ 🎉

from terraform-aws-atlantis.

@bsuv Should we close this issue?

from terraform-aws-atlantis.

Happy New Year @bsuv 🎉 ☃️

from terraform-aws-atlantis.

Happy New Year @antonbabenko 🎉 🍾

from terraform-aws-atlantis.

closing this issue for now - GitHub webhook subnets are whitelisted in the current release with the ability to limit IPs accessing the UI

from terraform-aws-atlantis.

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

from terraform-aws-atlantis.