Comments (14)
It is not a large bug. I'll fix it.
from termux-language-server.
Oh, I see. We must add manually these licenses which are treated differently.
from termux-language-server.
Can you try the latest version to see if it can fix this bug?
Yes, v0.0.15 fixes the issue. Thanks!
from termux-language-server.
Yes, only double quotes will trigger this bug. single quotes will not.
from termux-language-server.
Can you check if the lastest version can fix this bug? 🐛
from termux-language-server.
No, the error is different now. license=("MIT")
causes 'MIT' is not one of ['AGPL3', 'Apache', ...
.
from termux-language-server.
I forget to add MIT to legal licenses: https://github.com/termux/termux-language-server/blob/main/src/termux_language_server/assets/json/PKGBUILD.json#L73-L105
from termux-language-server.
I forget to add MIT to legal licenses
Shouldn't it be accepting any of the SPDX license identifiers?
https://spdx.org/licenses/
Maybe with some occasional exceptions for stuff like the BSL-1.1 which has particularly onerous restrictions.
from termux-language-server.
Android Termux's build.sh
and Gentoo's *.ebuild
use SPDX. https://github.com/termux/termux-language-server/blob/main/src/termux_language_server/misc/licenses.py#L7
However, ArchLinux's PKGBUILD
not:
license (array)
This field specifies the license(s) that apply to the package. Commonly used licenses can be found in /usr/share/licenses/common. If
you see the package’s license there, simply reference it in the license field (e.g., license=('GPL')). If the package provides a
license not available in /usr/share/licenses/common, then you should include it in the package itself and set license=('custom') or
license=('custom:LicenseName'). The license should be placed in $pkgdir/usr/share/licenses/$pkgname/ when building the package. If
multiple licenses are applicable, list all of them: license=('GPL' 'FDL').
I have to handle it by list /usr/share/licenses/common
https://github.com/termux/termux-language-server/blob/main/src/termux_language_server/misc/pkgbuild.py#L200-L202
from termux-language-server.
This is the licenses which Archlinux's PKGBUILD used. MIT
is missing. I doubt this is upstream's forgotness?
from termux-language-server.
License families MIT
and BSD
are treated differently. You can read more here.
from termux-language-server.
Can you try the latest version to see if it can fix this bug?
from termux-language-server.
Note: Arch Linux is currently undergoing a transition to SPDX style identifiers. Some issues may still require ironing out. This section focuses on the SPDX format. If you encounter any trouble, please report them and discuss with the community.
Yes, When I start to use archlinux, it haven't yet support SPDX. Good changes! 👍
from termux-language-server.
There is one thing need to be noticed. Although this language server can handle quotes in diagnosis, the completion will not complete quotes. That is, user can get completion like x86_64
, x86_64_v3
, not "x86_64"
or 'x86_64'
. (However, this feature is also can be tried to realized in future, if more people want to complete quotes)
from termux-language-server.
Related Issues (5)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from termux-language-server.