Comments (7)
We (me, and @TerminalFi) discussed this before in a private chat. We didn't think this is solvable due to ST's API limitation.
This was the conclusion made by me:
They actually have different view ids. I try to add
@classmethod
def applies_to_primary_view_only(cls) -> bool:
return False
but now both views sent a payload
I didn't find something like "active_buffer()" from API docs.
it's either
- both views'
on_modified_async
get triggered - or only primary (original) view's
on_modified_async
get triggered
but both have their own issues
from lsp-copilot.
Super interesting! I wonder if a warning could be displayed..? That might be less confusing than not seeing Copilot (it took me a second to understand what was going on - since I had traced the issue before, I got it, but it could be confusing to someone who doesn't know?)
from lsp-copilot.
It's something we are still considering. We might need to open a FR with Sublime.
from lsp-copilot.
Hmmm... seems get a working fix but I am not sure whether it causes other issues.
from lsp-copilot.
I haven't looked into the code of this package but I guess LSP must be handling such cases already? Maybe should get inspiration from there?
Not sure if relevant but LSP checks view.is_primary()
in some places.
from lsp-copilot.
I haven't looked into the code of this package but I guess LSP must be handling such cases already? Maybe should get inspiration from there?
Yeah. LSP seems working fine. Will check later.
from lsp-copilot.
Just confirmed, it works! Thank you so much for fixing this!!
from lsp-copilot.
Related Issues (20)
- Not working: completions is always empty HOT 2
- Incompatible with any sublime-workspace? HOT 3
- Settings documentation HOT 15
- Incompatibility between LSP-copilot and LSP-ruff HOT 1
- Unofficial specs for Github Copilot plugin-agent.js interactions
- Failed resolving Node.js Runtime HOT 3
- Investigate how to supported dedicated Copilot Environments (Org Tenants) HOT 6
- popup width HOT 6
- LSP-Copilot not working! HOT 16
- How can I start the Copilot LSP server? HOT 3
- Unable to see Copilot: Sign in on command palette HOT 14
- How to turn Github Copilot off in one file or turn it off temporarily? HOT 14
- does it support sublime text3? HOT 2
- Suggestion: key for closing the suggestions panel HOT 7
- Question: is there any keybindings for choosing the next suggestion? HOT 2
- Error: "Failed resolving Node.js Runtime. Please see Sublime Text console for more information." HOT 11
- How to trigger manually? HOT 5
- How often does copilot.vim get updated? HOT 8
- Completing when I press tab, even though hook_to_auto_complete_command is false HOT 3
- TAB key still accepts completion when other key is chosen in config. HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from lsp-copilot.