tensorflowjs_converter on .keras file messes up weights about tfjs HOT 6 CLOSED

Hi, @smidm

I apologize for the delayed response and as far I know the TensorFlow.js converter currently does not support converting Keras models saved in the new format .keras . it's still relatively new and hasn't been fully integrated with the TensorFlow.js converter yet so I completely agree with you in my view, tensorflowjs_converter should provide a user-friendly error message explicitly stating its lack of support for the .keras format. An informative message such as " .keras file format is not currently supported by tensorflowjs_converter. Please refer to the documentation for supported formats" would enhance the user experience by offering clear guidance.

Meanwhile, as an alternative approach, could you explore exporting the model directly to TensorFlow.js Layers format using the Python API? This would allow us to compare the weights of the original Python model and the converted model. I'll discuss this issue within our internal meeting and will update you soon. thank you for bringing this issue to our attention, I really appreciate your efforts and valuable time.

# Python

import tensorflowjs as tfjs

def train(...):
    model = keras.models.Sequential()   # for example
    ...
    model.compile(...)
    model.fit(...)
    tfjs.converters.save_keras_model(model, tfjs_target_dir)

Thank you for your cooperation and patience.

from tfjs.

Thanks for the alternative approach. I have already figured out, before submitting the issue, but it took some time. IMO the tensorflowjs_converter should check if inputs are valid and throw an error if not. It'll save a lot of pain. I had similar problem in #8265.

from tfjs.

Hi, @smidm

Thank you for your suggestion regarding to add a link https://github.com/tensorflow/tfjs/tree/master/tfjs-converter to tensorflowjs_converter --help . I appreciate you bringing this to our attention.

I will be sure to share your feedback during our next internal meeting. The team will discuss it and take appropriate action if necessary.

If your issue has been resolved, please feel free to close this issue.

Thank you for your cooperation and patience.

from tfjs.

This issue has been marked stale because it has no recent activity since 7 days. It will be closed if no further activity occurs. Thank you.

from tfjs.

This issue was closed due to lack of activity after being marked stale for past 7 days.

from tfjs.

Are you satisfied with the resolution of your issue?
Yes
No

from tfjs.