Code Monkey home page Code Monkey logo

Comments (6)

SuryanarayanaY avatar SuryanarayanaY commented on April 27, 2024 1

Hi @QuantumCoder4 , @Aloqeely

I acknowledge the issue of overflow and attached gist for reference.The proposed fix might work it seems. Please feel free to raise a PR.

from tensorflow.

Aloqeely avatar Aloqeely commented on April 27, 2024

Your analysis and solution seem valid. Open a PR if you'd like, otherwise I can handle it

from tensorflow.

QuantumCoder4 avatar QuantumCoder4 commented on April 27, 2024

I am afraid I don't have time in these few days, I would appreciate it if you can help me to open one.

from tensorflow.

SuryanarayanaY avatar SuryanarayanaY commented on April 27, 2024

Hi @Aloqeely ,

I have a question. What happens if the value of delta =1 here keeping other two params same. It still might cause overflow ?

from tensorflow.

Aloqeely avatar Aloqeely commented on April 27, 2024

Line 83 in sequence_ops.cc:

if (delta > 0) {
      OP_REQUIRES(
          context, start <= limit,
          errors::InvalidArgument(
              "Requires start <= limit when delta > 0: ", start, "/", limit));
    }

In that case, this if statement would get triggered since delta = 1, and then start <= limit would get evaluated to false so the function will raise an error

from tensorflow.

cantonios avatar cantonios commented on April 27, 2024

The proposed fix above won't work - it leads to different behavior. See the discussion in the (now closed) PR #64144.

Someone can pick that up if they like.

from tensorflow.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.