Build configuration is missing definitions about model-analysis HOT 11 CLOSED

I see, thanks for looking into this!

It would be nice to have CI support! Let me check with some folks to see whether there's a preferred solution or whether Travis CI would be fine.

from model-analysis.

Hi Sergei,

What command did you run? If you would like to generate whl file from source codes, you could simply run python bdist setup.py.

from model-analysis.

I wanted to run tests with Bazel. Would you recommend running them via e.g. pytest instead?

from model-analysis.

It turns out that our BUILD files need to be fixed quite a bit to get them to work. We'll work on fixing the BUILD files and pushing a new version with the fixed BUILD files soon. In the meantime, you can try running the tests directly with Python. Sorry for the inconvenience, and thanks for your patience!

from model-analysis.

Okay, after some discussion, we'll be removing the BUILD files for the Python targets for now, since they don't really add much. Could you try running the tests with Python directly, and let us know if you run into any issues?

from model-analysis.

I have tried running the tests locally:

============== 23 failed, 85 passed, 1 warnings in 247.46 seconds ==============

most failures involve the repr of dilll internals and are tricky to diagnose. Full output of pytest: failures.txt

from model-analysis.

My guess is that they have something to do with Beam. Which version of Beam do you have installed?

from model-analysis.

2.6.0 which matches the apache-beam[gcp]>=2.5,<3 constraint in setup.py.

I have the same number of failures with 2.5.0 and 2.4.0, and the error messages look similar. Could it be the dill version then?

from model-analysis.

The failures are caused by pytest. I think it instruments unittest classes (or possibly instances) in a way which makes them non-pickleable. Therefore, the error: "cannot pickle generators".

Interestingly, the error goes away if pytest is executed with the--pdb flag :)

Would you accept a PR adding Travis CI support?

from model-analysis.

Okay, so I checked with some other folks, and it looks like the plan is to set up a CI solution similar to what we have with the TensorFlow repository. Thanks for offering to add Travis CI support though!

from model-analysis.

Thanks for checking, closing the issue.

from model-analysis.