Code Monkey home page Code Monkey logo

Comments (17)

dlight avatar dlight commented on May 18, 2024 11

The CLA by itself doesn't prevent this fork from merging changes from upstream, because Audacity is still released as GPL v2. They would need to change the license into one incompatible with GPL v2 (like GPL v3) to prevent merges. At this point this fork needs to decide whether they want to stay GPL v2 (and stop merging changes from upstream) or follow upstream and relicense to GPL v3 as well.

But if upstream changes license to GPL v3 as they announced it's very easy for this repository to immediately relicense to GPL v3. GPL v3 is a better license overall (more importantly, it's compatible with the Apache license so this opens up adding Apache-licensed dependencies) so it would be a good change by itself.

In order to do this, this repository should request any new PR to be licensed as "GPL v2 or GPL v3", or even "GPL v2 or later". This doesn't require a CLA and makes a future license change almost automatic: the code is currently GPL v2 but as soon as upstream changes license to GPL v3, this project can just merge the commit with the license change and update LICENSE.txt to state the code is GPL v3 now (with portions "GPL v2 or GPL v3" and, likely, new code from upstream that is GPL v3 only).

Requiring "GPL v2 or GPL v3" for new contributions wouldn't force the fork to eventually relicense to GPL v3 either: it would still be possible to keep GPL v2 and stop merging upstream changes. So IMO this is a no-brainer.

from tenacity-legacy.

emabrey avatar emabrey commented on May 18, 2024 11

I think we should detach. If we really need to move code over we can cherry-pick patches and push them as commits using git cherry-pick -n <commit> (which supports non consecutive commits so with some care we could exclude any commits with objectionable code) and setting audacity/audacity as a git remote other than origin or upstream. That makes it not a fork, but it still lets us fetch+merge/pull. Does that sound reasonable to people who are or potentially may contribute? Only thing is we would want this remote to be on a separate branch other than master, that way any code we theoretically might move from them to us has to move onto master from a branch we already control, and so master can not have them as a direct upstream remote at all.

from tenacity-legacy.

dlight avatar dlight commented on May 18, 2024 7

And yep, upstream can't easily merge improvements made in this fork because the contributors may not have signed the CLA. That's one reason GCC dropped its CLA requirement.

from tenacity-legacy.

EricBright avatar EricBright commented on May 18, 2024 4

If we ever want to establish a foundation (suggested here #28, a big if, I know), and if copyright reassignment to the foundation becomes a thing, then detaching would be the most logical step. So, I 2nd that too.

from tenacity-legacy.

fugidev avatar fugidev commented on May 18, 2024 3

Is including new code from upstream even a option, since that's CLA licensed from now on?

from tenacity-legacy.

Sciss avatar Sciss commented on May 18, 2024 2

Is including new code from upstream even a option, since that's CLA licensed from now on?

Yes, this direction is no problem, because the project is still under GPL. That the contributors give up their rights to WSM Group has nothing to do with the fork. The opposite would be impossible - downstream changes cannot be used by WSM Group if there is no corresponding CLA signature for their terms.

from tenacity-legacy.

jesec avatar jesec commented on May 18, 2024 2

I am not familiar with audacity (and its community). I just saw the news, and I would like to put my two cents in:

Github severely limits the capabilities of a Github "fork". There is no code search, the repo not listed in search results by default, will prompt every committer to open a PR to the root repo (the "bad" one now I assume) whenever there is a push and features like Actions and Discussions are limited.

Technically, Github forks are just a non-default and invisible branch of the root repo. To demonstrate:

audacity/audacity@ced144b

The Github "fork" function is a convenient method to contribute to a project but is an awfully bad idea if you wish to maintain a permanent fork.

and Github does not provide a convenient way to "detach", and AFAIK the only way is to delete and recreate the repo, losing all data (stars, watchers, issues, PRs, comments) in the process. If you wish to maintain a permanent fork, for the sake of the project, you should not use a Github fork, and you should "detach" the project ASAP (to limit the damage).

Edit: Apparently, now it might be possible to contact GitHub support to ask them to detach the repo.

from tenacity-legacy.

peepo5 avatar peepo5 commented on May 18, 2024 2

Wait, I second it, but what do I say now? I third it?
Anyways, I support this detachment idea.

from tenacity-legacy.

emabrey avatar emabrey commented on May 18, 2024 2

@cookiengineer I am submitting the detach request on behalf of the organization.

from tenacity-legacy.

rezidentvx avatar rezidentvx commented on May 18, 2024

Please also update the original post with links to comments here that mitigate/promote/etc the different thoughts. Helps aggregate/track.

from tenacity-legacy.

 avatar commented on May 18, 2024

There is a small issue with this: In my attempts today, to figure out the current state of the various forks, I tried to use a tool to find the most active forks of the original project. Of course, this project was not among them.

from tenacity-legacy.

Semisol avatar Semisol commented on May 18, 2024

Most good forks have detached from the original repo.

from tenacity-legacy.

 avatar commented on May 18, 2024

Most good forks have detached from the original repo.

So I see, and I understand why... I hope you can suggest a solution to the issue this creates, where users can't easily (or, at all) find out what their options (including this one) are?

from tenacity-legacy.

Semisol avatar Semisol commented on May 18, 2024

You should be able to find them via:

  • searching "audacity fork", where this fork comes up
  • the wikipedia page for Audacity
  • Twitter and other platforms

from tenacity-legacy.

 avatar commented on May 18, 2024

So "just search, and hope you find them all" is where this is at? I've done that and more and I'm 90 minutes in and it is still entirely unclear what the state of things is, as a result of 'unknown unknowns'.

Just to be clear, I'm not blaming or arguing with you, I totally get why you did this. I'm just not sure how to resolve the situation. Actually, at this point I'm pretty sure it can't be resolved.

from tenacity-legacy.

Semisol avatar Semisol commented on May 18, 2024

There is nothing we can do, detaching has been done. I hope we could have easier discoverability for all forks, but if you are wondering the major forks, they have been listed here: https://en.wikipedia.org/wiki/Audacity_(audio_editor)#Derivatives, note that DA isn't a telemetry removal focused fork

from tenacity-legacy.

 avatar commented on May 18, 2024

Thanks mate :)

from tenacity-legacy.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.