[Bug] Cannot decode value using Protobuf converter when fetching previous workflow result about sdk-php HOT 2 CLOSED

@benkelukas I have investigated the problem. Try to do the following:

1. In your WorkflowInterface add explicit attribute for the return type:

interface GreetingWorkflowInterface
{
    /**
     * @param string $name
     * @return WorkflowResult
     */
    #[WorkflowMethod(name: "SimpleActivity.greet")]
    #[ReturnType(WorkflowResult::class)]
    public function greet(string $name);
}

2. In the command don't forget that the result object is now WorkflowResult. Don't try to print it, and use on of the getters:

$output->writeln(sprintf("Result:\n<info>%s</info>", $run->getResult()->getGreeting()));

Hope, it will help you. Waiting for you feedback.

from sdk-php.

Hi @seregazhuk

thanks a lot for taking a look at this, it works! :)

I suppose I could've tried this by myself, however, there is the ExpectedType attribute on the ReturnType attribute's type argument, so I kinda supposed (wrongly) that this is not possible.

Maybe it would be also good to update docs to mention that one can, in fact, use PHP protobuf messages and what to do when one wants to use it for Workflow return types, as I think it's a pretty good way how to structure data passing between activities / worfklows - but I understand that not everybody wants to go through the hassle of generating PHP code from .proto files - not sure if it is in scope for the docs.

There remains one little caveat for me: PHPStorm complains that I've provided unexpected type to the ReturnType annotation, it's nothing serious and I can disable inspections for statement, but maybe the attribute could be expanded to allow custom types somehow?

Thanks again for taking the time to help me, You guys rock! :)

I'm closing the issue, cheers!

from sdk-php.