Code Monkey home page Code Monkey logo

Comments (9)

johache avatar johache commented on August 26, 2024

It was a design choice to let the user override the request made by the website.
Re-reading the specs, I do understand that if the request says no video, the stream MUST not contain a video track.
http://www.w3.org/TR/2015/WD-mediacapture-streams-20150414/#idl-def-MediaStreamConstraints

@agouaillard : what do you think?

from adapterjs.

agouaillard avatar agouaillard commented on August 26, 2024

I think the spec is clear.
if the constraint is videoL false, the resulting media stream MUST not have
a video track.
In such case it makes no sense to have a prompt for video at all (you take
the risk to start a video capturer for nothing).

On Thu, Apr 30, 2015 at 10:07 AM, Jacques-Olivier HachΓ© <
[email protected]> wrote:

It was a design choice to let the user override the request made by the
website.
Re-reading the specs, I do understand that if the request says no video,
the stream MUST not contain a video track.

http://www.w3.org/TR/2015/WD-mediacapture-streams-20150414/#idl-def-MediaStreamConstraints

@agouaillard https://github.com/agouaillard : what do you think?

β€”
Reply to this email directly or view it on GitHub
#68 (comment).

Alex. Gouaillard, PhD, PhD, MBA

CTO - Temasys Communications, S'pore / Mountain View

President - CoSMo Software, Cambridge, MA

sg.linkedin.com/agouaillard

from adapterjs.

rpastro avatar rpastro commented on August 26, 2024

I agree with @agouaillard. We should not allow the user to overwrite what is being requested by the JS app.

Please note that this should also be applicable for the case where the constraint has audio: false. In this case the user should not be allowed to select a recording device.

from adapterjs.

johache avatar johache commented on August 26, 2024

Alright, ticket open in JIRA.

from adapterjs.

jauhenk avatar jauhenk commented on August 26, 2024

Hey,
Is it possible to remove video stream manually somehow? When I disable video track sound become disabled also.

from adapterjs.

johache avatar johache commented on August 26, 2024

1 - FYI, I implemented the forced respect of the constraints last week. it will be a part of the next release.
2 - Do you mean removing the video track from the stream while keeping the audio track ? MediaStream.removeTrack will also be in the next release.
Did you try getting the video track and setting it to enabled = false ?

from adapterjs.

jauhenk avatar jauhenk commented on August 26, 2024

Sounds good!
2 - Yes, but when we will have correct getUserMedia flow - all will be fine

  • Did you try getting the video track and setting it to enabled = false ?
  • Yes, and sound also became disabled after it.

from adapterjs.

jauhenk avatar jauhenk commented on August 26, 2024

Also could you please let me know when next release will be?

from adapterjs.

johache avatar johache commented on August 26, 2024

A release including those fixes was done on Aug 13, closing this issue.
https://temasys.atlassian.net/wiki/display/TWPP/WebRTC+Plugins

from adapterjs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.