Vimari not working in tabs opened from reading list when not connected to internet about vimari HOT 5 CLOSED

I just pushed a new release (v1.11), can you see if this is still an issue.

from vimari.

Thanks for the release! It appears to have fixed the background tab issue.

This issue still exists, however.

from vimari.

Can you elaborate.... if I have no internet connection, I cant access any of the links in my reading list at all as they are just links and still need a connection to download...?

from vimari.

Safari downloads web pages in the reading list so they can be read while offline (http://support.apple.com/kb/HT200294).

I can't replicate this issue consistently. Vimari sometimes loads fine in reading list items while offline — and sometimes has trouble.

I attempted to debug this. I don't think it's fixable. The breakdown occurs when:

• Page loads. injected.js evaluates and dispatches the 'getSettings' message
• Event listener in global.html handles the 'getSettings' message, calls getSettings()
• getSettings() attempts to dispatch a message to the page property of the active tab, but page is undefined (https://github.com/guyht/vimari/blob/master/vimari.safariextension/global.html#L52)

Sometimes page is undefined in this specific use case (offline + reading list page opened), other times it is not. I can't figure out why.

page is also undefined when a "Top Sites" tab is opened, though this is reasonable to not load Vimari here (and probably impossible).

from vimari.

Closing due to inactivity, re-open if you're still having these problems.

from vimari.