Error message when PipelineRun is missing parameters required by Pipeline is nonsensical about pipeline HOT 6 CLOSED

Fixing it should be quite simple. The aforementioned lines should be changed to something like:

			"PipelineRun %s/%s parameters is missing some parameters required by Pipeline %s/%s's parameters: %s",
			pr.Namespace, pr.Name, pr.Namespace, pipelineMeta.Name, err)

I do not have the time available at the moment to read the contribution guidelines and set up tools etc., so hoping someone else has :)

from pipeline.

@jvmdc so one "challenge" to this is, there might not be a named Pipeline in the namespace, as one could use inline spec, or resolvers.

from pipeline.

Isn't that also an issue in the other errors in the file then?

from pipeline.

Isn't that also an issue in the other errors in the file then?

Well, for example, this PipelineRun does not refer any Pipeline as everything is inlined.

from pipeline.

Isn't that also an issue in the other errors in the file then?

Well, for example, this PipelineRun does not refer any Pipeline as everything is inlined.

Sure, I get that - But shouldn't that also be a challenge for the other errors in the file linked such as https://github.com/tektoncd/pipeline/blob/main/pkg/reconciler/pipelinerun/pipelinerun.go#L502-L503?

from pipeline.

/assign @samagana

from pipeline.