Implement Pipeline Templating about pipeline HOT 11 CLOSED

This is the design doc for both templating and references, shared with members of knative-dev@.

from pipeline.

/assign @dlorenc
/meow space

from pipeline.

@bobcatfish:

from pipeline.

@bobcatfish should this issue be closed? I think its done now by the above PRs

from pipeline.

I think that actually templating with a Task's outputs still isn't implemented 🤔 But i think @dlorenc has a branch with this fixed so we can nearly close this...

from pipeline.

The other thing still missing is applying any templating at a Pipeline level.

from pipeline.

Can this be closed now?

from pipeline.

Only use case left is when you provide templating via a Pipeline:

kind: Pipeline
...
- name: deploy-bundle-test
  taskRef:
    name: deploy-with-kubectl
  inputSourceBindings:
  - name: workspace
    key: guestbook    
  - name: myImage
    key: redis-docker
    passedConstraint:
    - build-push
  params:
  - name: labels
    value: "${myImage.digest}@${workspace.revision}"

In the end the value should be expanded

from pipeline.

So I'm not 100% sure of the best way to test this. I added a test case to show that the PipelineRun reconciler does not expand these and will pass them to the TaskRun controller, and we have TaskRun tests that show they get expanded. But that doesn't feel very satisifying...

from pipeline.

At first glance, at least, that sounds like a reasonable set of tests to me.

from pipeline.

I added a test case to show that the PipelineRun reconciler does not expand these and will pass them to the TaskRun controller, and we have TaskRun tests that show they get expanded. But that doesn't feel very satisifying...

I hear you! I can't think of anything better at the moment - we could have an integration tests that passes the whole thing in and makes sure the right thing comes out, but that sounds pretty rough.

I was looking at some of the kubebuilder stuff today with @pwittrock and the integration tests it generates, which can instantiate the controllers and api server locally, could be an interesting way to test something like this.

That being said it kinda feels like overkill!

TL;DR: @dlorenc I think either add the test you've described or just decide it's not worth covering and leave it as is.

from pipeline.