Code Monkey home page Code Monkey logo

Comments (8)

nader-ziada avatar nader-ziada commented on May 28, 2024 3

A small addition might be to add notification.always which will be trigger at the end irrespective of Task run exit code.
For example:

kind: Pipeline
...
spec:
    tasks:
        - name: unit-test-kritis
          taskRef:
              name: make
          inputSourceBindings:
              - inputName: workspace
                sourceKey: kritis
          params:
              - name: makeTarget
                value: test
          notifications:
               failure:
                   ....
               success:
                  .....
               always:
                  .....

Simple use case would updating PR/Slack with a message confirming a test run or an docker image upload.

from pipeline.

nader-ziada avatar nader-ziada commented on May 28, 2024 1

/assign @pivotal-nader-ziada

from pipeline.

tanner-bruce avatar tanner-bruce commented on May 28, 2024

It would also be nice if the pipeline itself could have a generic success/failure notification. Perhaps it could also be templated to accept the task that failed? Having to put notifications for each and every task can be tedious and lead to copy and paste mistakes. This is something that I find Concourse is lacking.

from pipeline.

afrittoli avatar afrittoli commented on May 28, 2024

/assign @afrittoli

from pipeline.

afrittoli avatar afrittoli commented on May 28, 2024

Design document: https://docs.google.com/document/d/1ehhGngn2ulnjYX0HUxSyhQGAvcbabSa27UZs3RvZWwU/edit#

from pipeline.

afrittoli avatar afrittoli commented on May 28, 2024

@bobcatfish if thing we got enough input on the design doc now to close this issue and start prototyping - so I would close this one.

from pipeline.

bobcatfish avatar bobcatfish commented on May 28, 2024

Sound good to me @afrittoli !

from pipeline.

bobcatfish avatar bobcatfish commented on May 28, 2024

plz feel free to make a follow-up Issue to do POC and/or implement - we can add it to our 0.8 milestone!

from pipeline.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.