Comments (3)
a-roberts
commented on August 28, 2024
Note that on running the tests there are a few errors reported that we could do with resolving here too: for example,
Warning: React does not recognize the `dataIconPath` prop on a DOM element.If you intentionally want it to appear in the DOM as a custom attribute, spell itas lowercase `dataiconpath` instead. If you accidentally passed it from a parent component, remove it from the DOM element.
and
console.error node_modules/react-dom/cjs/react-dom.development.js:506
Warning: Cannot update during an existing state transition (such as within `
render`). Render methods should be a pure function of props and state.
console.error node_modules/jsdom/lib/jsdom/virtual-console.js:29
Error: Not implemented: window.scrollTo
For window.scrollTo, @ncskier suggests we could mock this function to be an empty function instead (e.g. with window.scrollTo = jest.fn(); in our beforeEach as part of a global test mock set up).
from experimental.
dibbles
commented on August 28, 2024
/assign
from experimental.
a-roberts
commented on August 28, 2024
Duane's implemented this, closing 😄
from experimental.
Related Issues (20)
- [Cloudevents] Add a roadmap for the cloudevents controller HOT 6
- [cloudevents] Use the cloudevents controller to Tekton triggers HOT 4
- [cloudevents] Controller Integration Roadmap HOT 2
- [pipelines-in-pipelines] Child pipeline is not adhering to timeout values passed from parent pipeline HOT 5
- Trusted Tasks PoC HOT 10
- [cloudevents] Supported Tekton Pipeline Cloudevents format HOT 1
- [Question][github app notifier] How to prevent github API limit throttling? HOT 4
- cloudevents Failed to emit cloud events no cloud events client found HOT 8
- Cleaning up pipeline runs from multiple namespaces HOT 4
- [pipelines-in-pipelines] Add a demo about using results between pipelines HOT 1
- [pipelines-in-pipelines] SIGSEGV in controller if parent PipelineRun is cancelled while child PipelineRun is starting HOT 1
- [trusted-task] Add config for users to determine whether apply verification HOT 1
- [trusted-task] Add e2e test HOT 4
- [trusted task] Verify task and pipeline when apply them HOT 4
- [trusted-task] Support Multiple Keys HOT 4
- Example Problem HOT 4
- Presubmits silently skipped if project does not have a presubmit-tests.sh file HOT 9
- [concurrency] Concurrency controller fails to cancel matching PipelineRuns HOT 9
- [concurrency] Reruns a pipelinerun hang in state PipelineRunPending HOT 4
- can I install commit-status-tracker without building it using Go ? HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from experimental.