Contributing Standards about openpogobot HOT 19 CLOSED

GitHub team @OpenPoGo/maintainers added. They will be tagged on every PR.

from openpogobot.

PR commits should be concise and squashed. One PR per feature, so generally 1 commit per PR (although there may be reasons to have multiple commits, as long as they make sense) imo.

from openpogobot.

Agreed. Also, we might have something like this to ensure everything is linted/PEP-8 conformant: https://github.com/markstory/lint-review

from openpogobot.

Agreed on the squashes. Will we also be squashing when merging?

from openpogobot.

rebase for merging I think?

from openpogobot.

I think we should rebase for merging and have contributors do the squashing.

from openpogobot.

Added stuff about contributors doing squashing

from openpogobot.

I'll take ownership of this issue to make sure it's completed

from openpogobot.

If someone could make a MAINTAINERS.md or wiki page with this information that'd be great

from openpogobot.

SGTM

from openpogobot.

👍 from me

from openpogobot.

+1

from openpogobot.

+1

from openpogobot.

how can we keep track of the number of approvals?

from openpogobot.

Are we just typing approval?
what if I want to thumbs up the main post instead?
+1

from openpogobot.

@jmeyer2k If you're talking about approvals on a PR - we'll use this.

Either is fine @Reaver01

from openpogobot.

+1

from openpogobot.

yeah, let's get that setup then.

from openpogobot.

All work must be done via PR's - even if done by a maintainer
All PRs must get two approvals/👍 from@OpenPoGo/maintainers before merging
All PRs must pass CI
One PR per feature
All PR commits must be concise and squashed (done via the contributor)
All PRs should be merged via rebase

Done.

All PRs must pass pep8 standards (this will be checked automatically)

See: #4

from openpogobot.